-
Notifications
You must be signed in to change notification settings - Fork 9
Migrate Hub billing page to the api's session-first flow #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tobihagemann
wants to merge
9
commits into
develop
Choose a base branch
from
feature/hub-billing-api-migration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
60a74b4
Migrate Hub billing from store to api and add invoice checkout
tobihagemann ce563d4
Add missing billing service prefix to api endpoint URLs
tobihagemann 147bd6c
Merge remote-tracking branch 'origin/develop' into feature/hub-billin…
tobihagemann 78b57b1
Adopt session-first billing flow: customer lookup, session links, ses…
tobihagemann f722818
Add invoice order summary with exact EspoCRM pricing and prorated sea…
tobihagemann 535f7f2
Merge branch 'develop' into feature/hub-billing-api-migration
tobihagemann aa42f11
Turn invoice checkout into a Paddle-style modal and make billing dial…
tobihagemann 1b0159e
expect custom_billing: null from store instead of the contract 404
tobihagemann 4497467
own the billing page's error texts instead of displaying backend mess…
tobihagemann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| - code: AT | ||
| name: Österreich | ||
| - code: BE | ||
| name: Belgien | ||
| - code: BG | ||
| name: Bulgarien | ||
| - code: HR | ||
| name: Kroatien | ||
| - code: CY | ||
| name: Zypern | ||
| - code: CZ | ||
| name: Tschechien | ||
| - code: DK | ||
| name: Dänemark | ||
| - code: EE | ||
| name: Estland | ||
| - code: FI | ||
| name: Finnland | ||
| - code: FR | ||
| name: Frankreich | ||
| - code: DE | ||
| name: Deutschland | ||
| - code: GR | ||
| name: Griechenland | ||
| - code: HU | ||
| name: Ungarn | ||
| - code: IE | ||
| name: Irland | ||
| - code: IT | ||
| name: Italien | ||
| - code: LV | ||
| name: Lettland | ||
| - code: LT | ||
| name: Litauen | ||
| - code: LU | ||
| name: Luxemburg | ||
| - code: MT | ||
| name: Malta | ||
| - code: NL | ||
| name: Niederlande | ||
| - code: PL | ||
| name: Polen | ||
| - code: PT | ||
| name: Portugal | ||
| - code: RO | ||
| name: Rumänien | ||
| - code: SK | ||
| name: Slowakei | ||
| - code: SI | ||
| name: Slowenien | ||
| - code: ES | ||
| name: Spanien | ||
| - code: SE | ||
| name: Schweden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| - code: AT | ||
| name: Austria | ||
| - code: BE | ||
| name: Belgium | ||
| - code: BG | ||
| name: Bulgaria | ||
| - code: HR | ||
| name: Croatia | ||
| - code: CY | ||
| name: Cyprus | ||
| - code: CZ | ||
| name: Czechia | ||
| - code: DK | ||
| name: Denmark | ||
| - code: EE | ||
| name: Estonia | ||
| - code: FI | ||
| name: Finland | ||
| - code: FR | ||
| name: France | ||
| - code: DE | ||
| name: Germany | ||
| - code: GR | ||
| name: Greece | ||
| - code: HU | ||
| name: Hungary | ||
| - code: IE | ||
| name: Ireland | ||
| - code: IT | ||
| name: Italy | ||
| - code: LV | ||
| name: Latvia | ||
| - code: LT | ||
| name: Lithuania | ||
| - code: LU | ||
| name: Luxembourg | ||
| - code: MT | ||
| name: Malta | ||
| - code: NL | ||
| name: Netherlands | ||
| - code: PL | ||
| name: Poland | ||
| - code: PT | ||
| name: Portugal | ||
| - code: RO | ||
| name: Romania | ||
| - code: SK | ||
| name: Slovakia | ||
| - code: SI | ||
| name: Slovenia | ||
| - code: ES | ||
| name: Spain | ||
| - code: SE | ||
| name: Sweden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Fill in production EspoCRM product IDs before deploy.
These placeholders are empty with TODO markers.
hubsubscription.js'sinvoiceProductId()returns this value directly and feeds it into bothloadInvoicePrice()(which silently no-ops on falsy/empty values, so the invoice price never loads) andinvoiceCheckout()(which POSTs it asproduct_idregardless of emptiness). Deploying with these unset will silently break the invoice checkout flow in production.Ensure these are populated with the actual EspoCRM Self-Hosted/Managed product IDs before this PR ships to production.
🤖 Prompt for AI Agents