Fix compatibility with mdformat 1.0.0#4
Conversation
|
@csala, can you validate the workflow so we can check the result of this PR on the CI? |
|
Thanks for the PR @kdeldycke ! Could we make it only about the version bumpings and keep the other changes for later? I would say that this would be fine:
But this I would separate:
|
Aha yeah sure! I'll split that PR and reduce its scope.
Oh perfect, thanks for detailing your requirements. I'll made the changes and ping you here once it is ready. |
|
I just reduced the diff and restricted the changes according your choices. I also squashed everything. You can now start the workflow to check everything OK before merging it upstream. |
KyleKing
left a comment
There was a problem hiding this comment.
Thank you both! I look forward to getting the mdformat dependency issues sorted out!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 11 11
=========================================
Hits 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No luck, I can't select this branch as target for #7. Do you mind adding the changes from #7 here @kdeldycke ? |
OK give me a couple of minutes to do it. |
|
Done. @csala, can you re-run the workflows to check everything's right? |
|
Thanks for the patience with all the back and forth @kdeldycke ! |
|
All tests are passing! Thanks @csala for the merge! |
Fix: #3
Given the big changes, I couldn't help but try to update things left and right:
mdformat 1.0.0owns requirement)pytest >= 8.4.0(first version to support Python 3.14)Sorry if this PR feels a bit bigger in scope than simply fixing
mdformat 1.0.0compatibility. So please tell me if some changes are too aggressive in which case I'll be happy to scale down my propositions.