Skip to content

feature: Delete user #470

Open
Nandos0804 wants to merge 7 commits into
csound:developfrom
Nandos0804:delete-user
Open

feature: Delete user #470
Nandos0804 wants to merge 7 commits into
csound:developfrom
Nandos0804:delete-user

Conversation

@Nandos0804
Copy link
Copy Markdown
Contributor

@Nandos0804 Nandos0804 commented Apr 14, 2026

While working on the delete user implementation i ended up reworking major part of the ide, i do not expect this PR to be merged but i gathered sparse idea that i had on multiple local branch and gather theme here.

@hlolli we could cherry pick some changes, continue on this or close without merge. But the fix have made the app throw 0 warning, less Cumulative layout shift on all /route and a mobile first UI/UX. It's the same but with some correction.

This PR introduces multiple small optimization to reduce the number of warning on the Developer Panel on Chromium browser. Most of those are related to react/Mui implementation. Removes yarn leftovers

Giuseppe Ernandez added 4 commits April 14, 2026 10:33
- fixes type warning
- refactor user page for mobile first approach
- minor UI optimization
- Updated menu-bar styles for better mobile support and adjusted z-index values.
- Enhanced modal component z-index for improved visibility.
- Refactored profile UI to use media queries for responsive design.
- Modified project editor styles to accommodate new layout requirements.
- Improved keyboard shortcuts layout and styling for better usability.
- Adjusted social controls styles for consistency and improved hover effects.
- Updated target controls to use new selectors for project ownership.
- Added mobileNavHeight constant for better layout management.
- Cleaned up unused imports and optimized selector functions.
@vlazzarini
Copy link
Copy Markdown
Member

@Nandos0804 @hlolli I'd just like to ask for you guys to thread with caution when merging to production. I'm in the final weeks of an undergraduate course that uses the IDE as a primary environment and students will be very confused if there are issues.

@Nandos0804 Nandos0804 marked this pull request as draft April 14, 2026 17:01
@Nandos0804
Copy link
Copy Markdown
Contributor Author

@Nandos0804 @hlolli I'd just like to ask for you guys to thread with caution when merging to production. I'm in the final weeks of an undergraduate course that uses the IDE as a primary environment and students will be very confused if there are issues.

Thank you for the message. For me it is safe to avoid entirely this PR. I didn't want to lose progress or ideas and archive them somewhere to discuss. I have marked this PR as draft.

@hlolli
Copy link
Copy Markdown
Member

hlolli commented Apr 14, 2026

@vlazzarini fair, we'll wait with this specific PR until
@Nandos0804 there are files there like config/paths and config/webpack that should be safe to remove, some leftover from create-react-app setup. See if removing them isn't safe?

@Nandos0804
Copy link
Copy Markdown
Contributor Author

Nandos0804 commented Apr 14, 2026

there are files there like config/paths and config/webpack that should be safe to remove, some leftover from create-react-app setup. See if removing them isn't safe?

Import were removed only if dead code. Function were streamline to reuse same modal. Legacy not used dependency were removed (yarn). Error first to avoid any data and unsafe ts pattern. I (locally, database is not the one on production so i'll report the link as per npm run start)tested with :

bot mobile or desktop. Based on background knowledge, i can't garante that outside of my test this code will be 100% retrocompatibile , but it should.

@hlolli
Copy link
Copy Markdown
Member

hlolli commented May 17, 2026

@Nandos0804 merge conflicts, do you know how to resolve them?

@Nandos0804
Copy link
Copy Markdown
Contributor Author

@Nandos0804 merge conflicts, do you know how to resolve them?

I'll take a look.

@Nandos0804
Copy link
Copy Markdown
Contributor Author

Nandos0804 commented May 17, 2026

@hlolli To finish reviewing this PR we still need to deploy the delete user function to Firebase,

➜  web-ide git:(delete-user) firebase deploy -P develop --only functions:delete_account
Error: Failed to authenticate, have you run firebase login?

I do not have the credentials to do so, i will stop at this step.

Main blocker on local is CORS request to a non existing function as mentioned above:

Access to fetch at 'https://us-central1-csound-ide-dev.cloudfunctions.net/delete_account' from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
delete-account-modal.tsx:46  POST https://us-central1-csound-ide-dev.cloudfunctions.net/delete_account net::ERR_FAILED

But it should work now, realigned with main. Husky pre-commit was giving me some error of not installed, fix it here.

@Nandos0804 Nandos0804 marked this pull request as ready for review May 17, 2026 09:49
@Nandos0804 Nandos0804 changed the title refactor(ui/ux): Delete user feature: Delete user May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants