Skip to content

Require access to current record for historical (#860) #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abeverley wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Require access to current record for historical (#860) #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/GADS.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1933,6 +1933,21 @@ any qr{/(record|history|purge|purgehistory)/([0-9]+)} => require_login sub {
: $action eq 'purgehistory'
? $record->find_deleted_recordid($id)
: $record->find_current_id($id);
# If it's a historical version, check that the user has access to the
# current version. This prevents the scenario whereby a user has a view
# limit on a particular condition, which potentially allows them access
# to the historical values of the record but not the current version.
# For the purposes of consistency, require that they always need access
# to the current version
if ($action eq 'history')
{
my $current = GADS::Record->new(
user => $user,
schema => schema,
);
# Will bork if no access
$current->find_current_id($record->current_id);
}
};

if ($@)
Expand Down
Loading