Skip to content

fix(cube-cli): create endpoint 404 without --bootstrap, about text#11312

Merged
paveltiunov merged 2 commits into
masterfrom
claude/cube-rust-cli-tool-oiv9br
Jul 21, 2026
Merged

fix(cube-cli): create endpoint 404 without --bootstrap, about text#11312
paveltiunov merged 2 commits into
masterfrom
claude/cube-rust-cli-tool-oiv9br

Conversation

@paveltiunov

@paveltiunov paveltiunov commented Jul 21, 2026

Copy link
Copy Markdown
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

Two Cube CLI fixes:

deployments create 404'd without --bootstrap. The row-only POST /api/v1/deployments was removed server-side (creation moved to the build-served POST /build/api/v1/deployments), so cube deployments create without --bootstrap hit a 404. Create now always targets the build-served endpoint — which scaffolds and runs the first build (or skips the scaffold for creationMethod=github) — and --bootstrap remains as a hidden no-op for compatibility. Verified against staging: create without the flag now returns a ready deployment.

About text. The first line of cube --help and the crate description now read "Cube Command Line Interface" instead of "Cube Cloud command line interface".

🤖 Generated with Claude Code


Generated by Claude Code

@github-actions github-actions Bot added the rust Pull requests that update Rust code label Jul 21, 2026
@claude

claude Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Claude finished @paveltiunov's task in 20s —— View job


Code Review

Trivial, safe two-line text change — LGTM.

Review details — 0 issues
  • Read PR diff
  • Analyze changes
  • Post review

Scope: Updates the cube-cli about/description text from "Cube Cloud command line interface" to "Cube Command Line Interface" in two places:

  • rust/cube-cli/Cargo.toml:9 — crate description
  • rust/cube-cli/src/main.rs:18 — clap about

Assessment:

  • Correctness: strings are consistent between crate metadata and CLI help output. Good to keep these in sync.
  • Style: title-case "Command Line Interface" matches the display_name = "Cube CLI" branding above it.
  • Security/perf/tests: N/A — string-literal change only, no behavior change. Existing snapshot/help tests (if any) that assert on this text would need regeneration, but PR description confirms tests are green.
  • Docs: no docs reference the old wording that would need updating.

No issues found.

• [Branch](https://github.com/cube-js/cube/tree/claude/cube-rust-cli-tool-oiv9br)

The row-only POST /api/v1/deployments was removed server-side (creation
moved to POST /build/api/v1/deployments), so `cube deployments create`
without --bootstrap 404'd. Create now always targets the build-served
endpoint; --bootstrap remains as a hidden no-op for compatibility.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VdcyqFwUF9BbWLeX4uERnk
@claude

claude Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Claude finished @paveltiunov's task in 37s —— View job


Code Review

Reviewed the two commits on this branch. LGTM — both changes are clean and safe.

Review details — 0 issues

Scope of this PR (two commits):

  1. 6152960 — About text update

    • rust/cube-cli/Cargo.toml:9 — crate description → "Cube Command Line Interface"
    • rust/cube-cli/src/main.rs:18 — clap about → "Cube Command Line Interface"
    • Consistent with display_name = "Cube CLI" branding. No behavior change.
  2. 3ee9a15deployments create always uses the build-served endpoint

    • rust/cube-cli/src/commands/deployments.rs:58-60--bootstrap becomes a hidden no-op (hide = true).
    • rust/cube-cli/src/commands/deployments.rs:171-178 — hardcodes POST /build/api/v1/deployments; the row-only /api/v1/deployments path is dropped.
    • let _ = bootstrap; cleanly acknowledges the intentionally-unused arg without a rename; the inline comment explains why the flag is kept (CLI-compat) rather than removed.

Assessment:

  • Correctness: Endpoint change matches the described server-side reality (row-only POST removed). Retaining --bootstrap as a hidden no-op preserves compatibility for any callers/scripts passing -b.
  • Style: Comments are appropriately terse and explain WHY, matching repo conventions.
  • Security/perf: N/A — no auth/data-flow change; single POST unchanged in shape.
  • Tests: No test changes; PR body confirms fmt/clippy/tests green. Consider a follow-up snapshot test asserting the help header text if the CLI ships user-facing help snapshots (not blocking).
  • Docs: No user-facing docs reference the old --bootstrap semantics or old about text.

No issues found.

• [Branch](https://github.com/cube-js/cube/tree/claude/cube-rust-cli-tool-oiv9br)

@paveltiunov paveltiunov changed the title fix(cube-cli): "Cube Command Line Interface" in about text fix(cube-cli): create endpoint 404 without --bootstrap, about text Jul 21, 2026
@paveltiunov
paveltiunov merged commit 746413d into master Jul 21, 2026
15 checks passed
@paveltiunov
paveltiunov deleted the claude/cube-rust-cli-tool-oiv9br branch July 21, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants