Skip to content

Introduce tm1-11 environment for tests #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MariusWirtz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce tm1-11 environment for tests #1392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/integration_test_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ on:
required: true
default: 'master'
environments:
description: 'JSON array of environments to test (e.g., ["tm1-11-cloud", "tm1-11-cloud"])'
description: 'JSON array of environments to test (e.g., ["tm1-11", "tm1-12-cloud", "tm1-11-cloud"])'
required: true
default: '["tm1-12-cloud","tm1-11-cloud"]'
default: '["tm1-11","tm1-12-cloud","tm1-11-cloud"]'

jobs:
test:
Expand Down Expand Up @@ -63,7 +63,13 @@ jobs:
TM1_CONNECTION: ${{ vars.TM1_CONNECTION }}
TM1_CONNECTION_SECRET: ${{ secrets.TM1_CONNECTION_SECRET }}

- name: Run tests
- name: Run required tests (tm1-11)
if: ${{ matrix.environment == 'tm1-11' }}
run: pytest Tests/

- name: Run optional cloud tests (tm1-12-cloud, tm1-11-cloud)
if: ${{ matrix.environment == 'tm1-12-cloud' || matrix.environment == 'tm1-11-cloud' }}
continue-on-error: true
Comment on lines +70 to +72

Copilot AI Apr 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes the cloud environments' test step continue-on-error: true, which will allow the workflow to pass even when those tests fail. If the intent is only to reduce flakiness from remote disconnects, consider documenting this behavior explicitly in the workflow (or in the PR description) and/or using job-level optionality so it's clear that failures are being tolerated and won't block merges.

Copilot uses AI. Check for mistakes.
run: pytest Tests/
Comment on lines +66 to 73

Copilot AI Apr 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test execution is now gated by two specific if: conditions, so if inputs.environments contains any value other than tm1-11, tm1-12-cloud, or tm1-11-cloud, no pytest step will run and the job can still succeed (only artifacts/comments run). Consider reverting to an unconditional pytest Tests/ step and instead controlling required-vs-optional behavior via job-level continue-on-error (e.g., based on matrix.environment != 'tm1-11') so every environment always runs tests.

Copilot uses AI. Check for mistakes.

- name: Upload test results
Expand Down
Loading