Skip to content

Fix error message formatting in _handle_proxies and grammatical error #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JosephPTM1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix error message formatting in _handle_proxies and grammatical error #1398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TM1py/Services/RestService.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def _handle_proxies(self, proxies: Union[Dict, str]):
try:
return json.loads(proxies)
except JSONDecodeError:
raise ValueError("Invalid JSON passed for argument 'proxies': %s", proxies)
raise ValueError(f"Invalid JSON passed for argument 'proxies': {proxies}")

# handle invalid type
raise ValueError("Argument of 'proxies' must be None, dictionary or JSON string")
Expand Down Expand Up @@ -1133,7 +1133,7 @@ def translate_to_boolean(value) -> bool:
elif isinstance(value, str):
return value.replace(" ", "").lower() == "true"
else:
raise ValueError("Invalid argument: '" + value + "'. Must be to be of type 'bool' or 'str'")
raise ValueError("Invalid argument: '" + value + "'. Must be of type 'bool' or 'str'")

@staticmethod
def b64_decode_password(encrypted_password: str) -> str:
Expand Down
Loading