Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cucumber-messages/ruby/Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
# frozen_string_literal: true
source 'https://rubygems.org'

# Use an older protobuf on JRuby
gem 'google-protobuf', '~> 3.2.0.2' if RUBY_PLATFORM == 'java'

gemspec
8 changes: 4 additions & 4 deletions cucumber-messages/ruby/Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
include default.mk

.deps: lib/cucumber/messages_pb.rb
.deps: lib/cucumber/messages.pb.rb

lib/cucumber/messages_pb.rb: messages.proto
protoc -I. --ruby_out lib/cucumber $<
lib/cucumber/messages.pb.rb: messages.proto
bundle exec rake protobuf:compile[.,.,lib/cucumber]

clean:
rm -f lib/cucumber/messages_pb.rb
rm -f lib/cucumber/messages.pb.rb
1 change: 1 addition & 0 deletions cucumber-messages/ruby/Rakefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# encoding: utf-8
require 'rubygems'
require 'bundler'
load 'protobuf/tasks/compile.rake'
Comment thread
aslakhellesoy marked this conversation as resolved.
Outdated
Bundler::GemHelper.install_tasks

$:.unshift File.expand_path("../lib", __FILE__)
Expand Down
3 changes: 1 addition & 2 deletions cucumber-messages/ruby/cucumber-messages.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/cucumber/cucumber/blob/master/cucumber-messages/ruby',
}

# Users of JRuby should use google-protobuf 3.2.0.2 (later versions don't work)
s.add_dependency('google-protobuf', ['>= 3.2', '<= 3.8'])
s.add_dependency 'protobuf', '~> 3.10'
s.add_dependency 'json', '~> 2.2', '>= 2.2.0'
s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.1'
s.add_development_dependency 'rspec', '~> 3.9', '>= 3.9.0'
Expand Down
2 changes: 1 addition & 1 deletion cucumber-messages/ruby/lib/cucumber/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# protoc-generated file
messages_pb.rb
messages.pb.rb
2 changes: 1 addition & 1 deletion cucumber-messages/ruby/lib/cucumber/messages.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require 'cucumber/messages_pb'
require 'cucumber/messages.pb'
require 'cucumber/messages/binary_to_message_enumerator'
require 'cucumber/messages/ndjson_to_message_enumerator'
require 'cucumber/messages/protobuf_delimited'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ class NdjsonToMessageEnumerator < Enumerator
def initialize(io)
super() do |yielder|
io.each_line do |json|
yielder.yield(Cucumber::Messages::Envelope.decode_json(json))
args = JSON.parse(json)
yielder.yield(Cucumber::Messages::Envelope.new(args))
end
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Cucumber
module Messages
module WriteNdjson
def write_ndjson_to(io)
json = self.class.encode_json(self)
json = self.to_json
ob = JSON.parse(json)
remove_empties(ob)
io.puts(JSON.generate(ob))
Expand All @@ -27,4 +27,4 @@ def remove_empties(ob)
end
end
end
end
end
4 changes: 1 addition & 3 deletions cucumber-messages/ruby/messages.proto
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
syntax = "proto3";
package io.cucumber.messages;
Comment thread
aslakhellesoy marked this conversation as resolved.
option ruby_package = "Cucumber.Messages";
option go_package = "messages";
package cucumber.messages;

// When removing a field, replace it with reserved, rather than deleting the line.
// When adding a field, add it to the end and increment the number by one.
Expand Down