Skip to content

fix: pin npm to 11.x in the npm deploy job - #626

Merged
mahmoud-elmorabea merged 1 commit into
mainfrom
pin-npm-11
Jul 30, 2026
Merged

fix: pin npm to 11.x in the npm deploy job#626
mahmoud-elmorabea merged 1 commit into
mainfrom
pin-npm-11

Conversation

@mahmoud-elmorabea

@mahmoud-elmorabea mahmoud-elmorabea commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The 6.6.0 deploy created its git tag but never published: Deploy to npm failed with EBADENGINE.

npm error code EBADENGINE
npm error notsup Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"}
npm error notsup Actual:   {"npm":"10.8.2","node":"v20.20.2"}

deploy-sdk.yml sets up node 20 and then installs npm globally with @latest. npm@latest is now 12.0.2, and npm 12 dropped node 20 — so the install fails before publishing starts.

The step exists to get OIDC support, which needs >= 11.5.1. @latest was therefore asking for more than the job needs, and this would have broken every deploy from the day npm 12 shipped, not just this one. Pinning to the 11.x line keeps OIDC working and makes any move to npm 12 a deliberate change alongside node-version.


Note

Low Risk
CI-only change to the npm install version in the release workflow; no runtime SDK or auth logic changes.

Overview
Fixes SDK npm publish failures after git tags were created but Deploy to npm never ran.

The deploy-npm job still uses Node 20, but the global npm install step was changed from npm@latest to npm@11. npm 12 (what @latest resolves to now) requires Node ≥ 22.22.2, which triggered EBADENGINE before npm publish could run. Pinning to the 11.x line keeps OIDC support (needs npm ≥ 11.5.1) while staying compatible with Node 20.

Inline comments in deploy-sdk.yml document that npm 12 should only be adopted together with a deliberate node-version bump, not via drifting @latest.

Reviewed by Cursor Bugbot for commit 6a4dc51. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • Android APN: 626.1.0 (29757187)
  • iOS APN: 626.1.0 (29757187)
  • iOS FCM: 626.1.0 (29757187)

@mahmoud-elmorabea
mahmoud-elmorabea marked this pull request as ready for review July 30, 2026 16:09
@mahmoud-elmorabea
mahmoud-elmorabea requested a review from a team as a code owner July 30, 2026 16:09
@mahmoud-elmorabea mahmoud-elmorabea changed the title ci: pin npm to 11.x in the npm deploy job fix: pin npm to 11.x in the npm deploy job Jul 30, 2026
The 6.6.0 deploy created its git tag then failed to publish: the job installs
npm globally with @latest, which has moved to 12.0.2, and npm 12 requires
node ^22.22.2 || ^24.15.0 || >=26.0.0 while the job sets up node 20.

  npm error code EBADENGINE
  npm error notsup Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"}
  npm error notsup Actual:   {"npm":"10.8.2","node":"v20.20.2"}

The step exists to get OIDC support, which needs >= 11.5.1, so @latest was
asking for more than the job needs and would have broken every deploy from the
day npm 12 shipped. Pinning to 11.x keeps OIDC working and makes moving to
npm 12 a deliberate change made together with node-version.

Typed as fix rather than ci so that merging this cuts a release: 6.6.0 is
tagged but was never published to npm, and the release it triggers is what
actually ships the inbox that already landed on main.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mahmoud-elmorabea
mahmoud-elmorabea merged commit 7c6f6cd into main Jul 30, 2026
11 checks passed
@mahmoud-elmorabea
mahmoud-elmorabea deleted the pin-npm-11 branch July 30, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants