fix: pin npm to 11.x in the npm deploy job - #626
Merged
Conversation
Contributor
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mahmoud-elmorabea
marked this pull request as ready for review
July 30, 2026 16:09
The 6.6.0 deploy created its git tag then failed to publish: the job installs npm globally with @latest, which has moved to 12.0.2, and npm 12 requires node ^22.22.2 || ^24.15.0 || >=26.0.0 while the job sets up node 20. npm error code EBADENGINE npm error notsup Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"} npm error notsup Actual: {"npm":"10.8.2","node":"v20.20.2"} The step exists to get OIDC support, which needs >= 11.5.1, so @latest was asking for more than the job needs and would have broken every deploy from the day npm 12 shipped. Pinning to 11.x keeps OIDC working and makes moving to npm 12 a deliberate change made together with node-version. Typed as fix rather than ci so that merging this cuts a release: 6.6.0 is tagged but was never published to npm, and the release it triggers is what actually ships the inbox that already landed on main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mahmoud-elmorabea
force-pushed
the
pin-npm-11
branch
from
July 30, 2026 16:19
3c8bf8a to
6a4dc51
Compare
matt-frizzell
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.6.0 deploy created its git tag but never published:
Deploy to npmfailed withEBADENGINE.deploy-sdk.ymlsets up node 20 and then installs npm globally with@latest.npm@latestis now 12.0.2, and npm 12 dropped node 20 — so the install fails before publishing starts.The step exists to get OIDC support, which needs
>= 11.5.1.@latestwas therefore asking for more than the job needs, and this would have broken every deploy from the day npm 12 shipped, not just this one. Pinning to the 11.x line keeps OIDC working and makes any move to npm 12 a deliberate change alongsidenode-version.Note
Low Risk
CI-only change to the npm install version in the release workflow; no runtime SDK or auth logic changes.
Overview
Fixes SDK npm publish failures after git tags were created but
Deploy to npmnever ran.The
deploy-npmjob still uses Node 20, but the global npm install step was changed fromnpm@latesttonpm@11. npm 12 (what@latestresolves to now) requires Node ≥ 22.22.2, which triggered EBADENGINE beforenpm publishcould run. Pinning to the 11.x line keeps OIDC support (needs npm ≥ 11.5.1) while staying compatible with Node 20.Inline comments in
deploy-sdk.ymldocument that npm 12 should only be adopted together with a deliberatenode-versionbump, not via drifting@latest.Reviewed by Cursor Bugbot for commit 6a4dc51. Bugbot is set up for automated code reviews on this repo. Configure here.