Skip to content

fix: Replace telemetry button with valid firmware CLI command #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwill747 merged 5 commits into from
May 26, 2026
Merged

fix: Replace telemetry button with valid firmware CLI command #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0318a34
fix: Replace hallucinated repeater admin commands with real ones
cwill747 May 19, 2026
e23a568
fix: Replace telemetry button with get repeat (telemetry is not a CLI…
cwill747 May 19, 2026
489c149
fix: Match multi-word commands in mock CLI response lookup
cwill747 May 25, 2026
0ec7ba3
fix: Resolve merge conflicts with main, keep both telemetry and get r…
cwill747 May 25, 2026
41feb2c
style: Fix ruff formatting in mock client
cwill747 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/meshcore_console/mock/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,11 @@ def logout_from_repeater(self, peer_name: str) -> None:
self._append_event({"type": EventType.REPEATER_LOGOUT, "data": {"peer_name": peer_name}})

def send_repeater_command(self, peer_name: str, command: str) -> dict:
cmd_key = command.strip().split()[0].lower() if command.strip() else ""
response_text = MOCK_CLI_RESPONSES.get(cmd_key, f"OK: {command}")
stripped = command.strip().lower()
cmd_key = stripped.split()[0] if stripped else ""
response_text = MOCK_CLI_RESPONSES.get(stripped) or MOCK_CLI_RESPONSES.get(
cmd_key, f"OK: {command}"
)
self._append_event(
{
"type": EventType.REPEATER_COMMAND_RESPONSE,
Expand Down
1 change: 1 addition & 0 deletions src/meshcore_console/mock/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
" Bob -82 dBm SNR 3.2 0 hops\n"
" Charlie -91 dBm SNR -1.0 0 hops"
),
"get repeat": "repeat: ON",

@chatgpt-codex-connector chatgpt-codex-connector Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep mock key parsing consistent for multi-word commands

MOCK_CLI_RESPONSES now stores "get repeat", but MockMeshcoreClient.send_repeater_command() only looks up the first token (command.strip().split()[0].lower()). In mock mode, pressing the new quick button sends get repeat and resolves key get, so the intended mock output (repeat: ON) is never returned and developers see the generic fallback instead, reducing parity with real repeater behavior during UI testing.

Useful? React with 👍 / 👎.

"telemetry": (
"Battery: 3.82V (74%)\n"
"Temperature: 32.1 C\n"
Expand Down
2 changes: 1 addition & 1 deletion src/meshcore_console/ui_gtk/views/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def _build_console_tab(self) -> Gtk.Box:
quick_row.set_margin_end(8)
quick_row.set_margin_top(8)
quick_row.set_margin_bottom(4)
for cmd in ("neighbors", "telemetry", "reboot", "ver"):
for cmd in ("neighbors", "telemetry", "get repeat", "reboot", "ver"):
btn = Gtk.Button.new_with_label(cmd)
btn.add_css_class("quick-cmd-btn")
btn.connect("clicked", self._on_quick_cmd, cmd)
Expand Down
Loading