fix: prevent MXFP8 amax aliasing with dSoftmaxOffset in bwd#4
Open
vedaanta wants to merge 1 commit into
Open
Conversation
…ttention backward In fused_attn_fp8_bwd, the amax pointers for dQ/dK/dV all pointed to output_dQ->amax.dptr. For MXFP8 (which doesn't use per-tensor amax), PyTorch's caching allocator could reuse this memory for the dSoftmaxOffset tensor. cuDNN's second bprop kernel then wrote amax_dQ to that address, corrupting d_softmax_offset[0]. Fix: use each tensor's own amax/scale pointers, and when aliasing with dSoftmaxOffset is detected, allocate scratch space for the amax outputs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
amax), PyTorch's caching allocator could reuse this memory for the dSoftmaxOffset tensor.
amax outputs.
Test plan