Skip to content

CM-61986-add-mcp-and-email-enrichment-from-claude-json#421

Merged
RoniCycode merged 5 commits intomainfrom
CM-61986-enrich-data-for-guardrails
Apr 9, 2026
Merged

CM-61986-add-mcp-and-email-enrichment-from-claude-json#421
RoniCycode merged 5 commits intomainfrom
CM-61986-enrich-data-for-guardrails

Conversation

@RoniCycode
Copy link
Copy Markdown
Collaborator

No description provided.

elsapet
elsapet previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good -- no blockers

One consideration would be that the .claude.json has no public-facing documentation that I can find, and so its structure is not necessarily stable (i.e. we cannot rely on oauthAccount.emailAddress always being present, for example). I see that we set email to None in this case, so I assume this instability is understood

Also, the branch name mentions MCP but I don't see any functionality around this -- @RoniCycode does it come in a separate PR?

@elsapet
Copy link
Copy Markdown
Collaborator

elsapet commented Apr 9, 2026

the .claude.json has no public-facing documentation that I can find, and so its structure is not necessarily stable

Discussed and this is understood ✅

Copy link
Copy Markdown
Collaborator

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good on my side -- @gotbadger are you happy to merge this one?

@RoniCycode RoniCycode merged commit f89bbe6 into main Apr 9, 2026
28 checks passed
@RoniCycode RoniCycode deleted the CM-61986-enrich-data-for-guardrails branch April 9, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants