docs: add Biome false positive pattern to Codacy skill guardrails#847
Merged
Conversation
…learnings Prevents repeat of PR #846 Codacy failure. Documents that Biome's SolidJS useQwikValidLexicalScope rule flags bare arrow functions at module scope in test files. Fix: use vi.fn() wrapper.
Deploying do-epub-studio with
|
| Latest commit: |
51e0b78
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3c08f62.do-epub-studio.pages.dev |
| Branch Preview URL: | https://fix-e2e-mobile-ci-failure-20.do-epub-studio.pages.dev |
Contributor
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the Biome
useQwikValidLexicalScopefalse positive pattern discovered in PR #846 to prevent future Codacy CI failures.Changes
agents-docs/LEARNINGS.md— Expanded Biome SolidJS entry with test file fix pattern (vi.fn()wrapper).agents/skills/codacy/SKILL.md— Added fix pattern section, Known Limitations entry, and Red Flag for bare arrow functions in test filesContext
PR #846 failed Codacy because
const t = (key: string) => key;in test files triggered Biome's SolidJS-specificuseQwikValidLexicalScoperule. The fix (vi.fn()wrapper) is now documented as a guardrail so agents won't repeat this pattern.