Skip to content

feat: remediate plan 071 audit findings — data integrity, harness, UI/UX#498

Merged
d-oit merged 1 commit into
mainfrom
feat/072-plan071-remediation
Jul 24, 2026
Merged

feat: remediate plan 071 audit findings — data integrity, harness, UI/UX#498
d-oit merged 1 commit into
mainfrom
feat/072-plan071-remediation

Conversation

@d-oit

@d-oit d-oit commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

Remediates findings from Plan 071 (codebase gap audit) across data integrity,
synchronization, agent harness, product honesty, and documentation.

ADRs Accepted

  • ADR 027: Canonical State and P2P Sync Bridge
  • ADR 028: Validated and Recoverable Local Data Boundaries
  • ADR 029: Manifest-Driven Agent Harness

Changes

Data Integrity (P0)

  • Add Zod validation for store hydration (replaces no-op type cast in store.ts:289)
  • Replace shallow isEntity/isClaim import guards with strict Zod schema validation
  • Fix deleteEntity to remove incoming links from other entities
  • Add session-only credential labeling for API keys

Harness & CI (P1)

  • Disable broken version-propagation workflow (references missing VERSION/CHANGELOG)
  • Make security scanners fail-closed (remove continue-on-error)
  • Add warnings-as-errors enforcement in quality gate script
  • Remove broken circular skill symlinks

Product Honesty (P1)

  • Rename "Semantic" search to "Ranked" (search is BM25, not vector/embedding)
  • Remove no-op "Re-sync" button from AI Harness
  • Fix "coming soon" tooltips to say "nothing to undo/redo"
  • Update metadata to reflect keyword search

Documentation (P2)

  • Update INDEX.md with current plan 072 status
  • Update GOAL.md with current architecture (Zustand + localStorage, not SQLite)
  • Mark historical Vite/SQLite phases in PHASES.md

Deferred to Plan 073

  • G2: Bidirectional Yjs/Zustand sync bridge
  • G5: UI/UX hardening (44px targets, ARIA tree, Playwright devices)
  • Full accessibility audit

Quality

  • Lint: clean
  • Typecheck: clean
  • Tests: 257 passed (26 files)
  • Build: clean

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
do-knowledge-studio Ready Ready Preview, Comment, Open in v0 Jul 24, 2026 6:55pm

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 2 duplication

Metric Results
Complexity 0
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Implements plan 072 to address 14 findings from the plan 071 codebase gap audit.

Data Integrity (P0):
- Add Zod validation for store hydration (replaces no-op type cast)
- Replace shallow import guards with strict Zod schema validation
- Fix entity deletion to remove incoming links from other entities
- Add session-only credential labeling for API keys

Harness & CI (P1):
- Disable broken version-propagation workflow (missing VERSION/CHANGELOG)
- Make security scanners fail-closed (remove continue-on-error)
- Add warnings-as-errors enforcement in quality gate script
- Remove broken circular skill symlinks

Product Honesty (P1):
- Rename 'Semantic' search to 'Ranked' (search is BM25, not vector)
- Remove no-op 'Re-sync' button from AI Harness
- Fix 'coming soon' tooltips to say 'nothing to undo/redo'
- Update metadata to reflect keyword search

Documentation (P2):
- Accept ADRs 027/028/029 (canonical state, validation, harness)
- Update INDEX.md with current plan 072 status
- Update GOAL.md with current architecture (Zustand, not SQLite)
- Mark historical Vite/SQLite phases in PHASES.md

Tests: 265 passed (8 new for link cleanup + Zod validation)
Quality: lint, typecheck, build all pass.
@d-oit
d-oit force-pushed the feat/072-plan071-remediation branch from e4eee74 to 78e564a Compare July 24, 2026 18:54
@d-oit
d-oit merged commit 072bd32 into main Jul 24, 2026
24 checks passed
@d-oit
d-oit deleted the feat/072-plan071-remediation branch July 24, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci config documentation Documentation improvements scripts skills tests Related to automated/manual tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants