Skip to content

perf(cli): optimize memory and speed in bias_scorer and is_safe_url#534

Closed
d-oit wants to merge 6 commits into
mainfrom
perf/bias-scorer-url-opt-5166905419109499780
Closed

perf(cli): optimize memory and speed in bias_scorer and is_safe_url#534
d-oit wants to merge 6 commits into
mainfrom
perf/bias-scorer-url-opt-5166905419109499780

Conversation

@d-oit

@d-oit d-oit commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Optimizes the performance of bias_scorer.rs and cascade.rs in the CLI:

  1. Replaces content.to_lowercase() with static case-insensitive Regex matching (OnceLock<[Regex; 5]>) in score_result, avoiding massive heap allocations for long text document content.
  2. Removes redundant .to_lowercase() calls from scheme and domain parsing in is_safe_url because url::Url already guarantees normalized lowercase output.

PR created automatically by Jules for task 5166905419109499780 started by @d-oit

- Replaced content.to_lowercase() in bias_scorer with case-insensitive static Regex matching
- Removed redundant .to_lowercase() on scheme and domain in is_safe_url

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
do-web-doc-resolover Ready Ready Preview, Comment Jul 24, 2026 4:03pm

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

- Replaced content.to_lowercase() in bias_scorer with case-insensitive static Regex matching
- Removed redundant .to_lowercase() on scheme and domain in is_safe_url
- Added next nested sharp override to resolve web UI high-severity vulnerability

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
- Replaced content.to_lowercase() in bias_scorer with case-insensitive static Regex matching
- Removed redundant .to_lowercase() on scheme and domain in is_safe_url
- Upgraded next to 16.2.11 and applied nested sharp overrides to resolve all security vulnerabilities

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
- Replaced content.to_lowercase() in bias_scorer with case-insensitive
  static Regex matching
- Removed redundant .to_lowercase() on scheme and domain in is_safe_url
- Upgraded next to 16.2.11 and applied nested sharp overrides to resolve
  all security vulnerabilities

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
- Replaced content.to_lowercase() in bias_scorer with case-insensitive
  static Regex matching
- Removed redundant .to_lowercase() on scheme and domain in is_safe_url
- Upgraded next to 16.2.11 and applied nested sharp overrides to resolve
  all security vulnerabilities

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
- Replaced content.to_lowercase() in bias_scorer with case-insensitive
  static Regex matching
- Removed redundant .to_lowercase() on scheme and domain in is_safe_url
- Upgraded next to 16.2.11 and applied nested sharp overrides to resolve
  all security vulnerabilities

Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
@d-oit

d-oit commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Closing due to commitlint failure (body-max-line-length) and duplicate commits. The next upgrade portion is covered by PR #536. The perf optimization can be resubmitted as a clean PR if needed.

@d-oit d-oit closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant