Remove misleading LanceDB naming#34
Open
FANNG1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #33.
Checks
make check-formatpassed.make lintpassed.uv run pytest tests/io/lance -vreported278 passed, 5 skipped, 2 xfailed, 2 xpassed, but the process exited with code 139 after printing the summary.uv run pytest -p no:benchmark tests/io/lance/test_lance_count_pushdown_coverage.py tests/io/lance/test_lance_factory_function.py tests/io/lance/test_lance_point_lookup.py tests/io/lance/test_lance_reads.py -vreported68 passed, 2 skipped, 2 xpassed, but also exited with code 139 after printing the summary.make typecheckfailed on existing mypy issues across tests and a few existing Lance typing mismatches; no failures appeared specific to the naming change.Notes
lancedbtext fromrg -i "lancedb|lance db"is the factual upstream URLhttps://github.com/lancedb/lance/....