feat: add blob v2 columns through merge_columns_df#39
Draft
everySympathy wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for adding BlobV2 columns through
merge_columns_dfby allowing callers to mark selected new columns as BlobV2 payload columns.Changes
blob_columnsparameter todaft_lance.merge_columns_df/merge_columns_from_df.lance.blob_array(...)before merging.take_blobs.Testing
uv run --python /usr/bin/python3.11 pytest tests/io/lancedb/test_fast_path_merge.py::TestBasicCorrectness::test_fast_path_adds_blob_v2_column -vEXIT:0Additional investigation:
test_fast_path_merge.pyon this branch:38 passed, then process exits13937 passed, 1 deselected, then process exits13937 passed, then process exits139EXIT:139.0.Notes / Risks
The
139is a pre-existing native teardown / heap corruption issue in the current fast-path merge tests, not introduced by this BlobV2 add-column change.The BlobV2 add-column implementation intentionally bypasses fast path because the current raw
LanceFileWriter+ manually stitchedFragmentMetadatafast path is the path associated with the native exit crash. This PR should either be submitted as draft with the known fast-path stability issue called out, or submitted after a separate tracking issue is filed for the existing fast-path crash.Suggested tracking issue: