Skip to content

feat: unified view logging – count article views on post open #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebelchris merged 1 commit into from
Jul 28, 2026
+10 −12
Merged

feat: unified view logging – count article views on post open #4026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/posts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4617,11 +4617,11 @@ describe('mutation viewPost', () => {
expect(notifyView).toBeCalledTimes(1);
});

it('should should not submit view event for articles', async () => {
it('should submit view event for articles', async () => {

@rebelchris rebelchris Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the intentional behavior flip (was should should not submit view event for articles asserting 0 calls). The auth/permission tests for the mutation are untouched — only the article-exclusion assertion changed.

loggedUser = '1';
const res = await client.mutate(MUTATION, { variables });
expect(res.errors).toBeFalsy();
expect(notifyView).toBeCalledTimes(0);
expect(notifyView).toBeCalledTimes(1);
});
});

Expand Down
18 changes: 8 additions & 10 deletions src/schema/posts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3408,16 +3408,14 @@ export const resolvers: IResolvers<unknown, BaseContext> = {
): Promise<GQLEmptyResponse> => {
const post = await ctx.con.getRepository(Post).findOneByOrFail({ id });
await ensureSourcePermissions(ctx, post.sourceId);
if (post.type !== PostType.Article) {
await notifyView(
ctx.log,
post.id,
ctx.userId,
ctx.req.headers['referer'],
new Date(),
post.tagsStr?.split?.(',') ?? [],
);
}
await notifyView(

@rebelchris rebelchris Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed guard existed to avoid double-counting articles: their view was historically produced by the GET /r/:postId redirector when the user clicks "Read article", so viewPost deliberately no-oped for them.

Removing it is safe because dedup already happens downstream, not here: the views worker drops duplicate View rows per (userId, postId) within a one-week window, and the streak only increments once per day. Video posts have relied on exactly this for a while (they track on open and go through the redirector on click), so this puts articles on the same, already-proven path.

Also worth noting for review: ensureSourcePermissions still runs before the publish, and the mutation's API shape is unchanged — clients that don't call viewPost for articles yet (current prod frontend) are unaffected, which is why there's no deploy-order constraint with dailydotdev/apps#6380.

ctx.log,
post.id,
ctx.userId,
ctx.req.headers['referer'],
new Date(),
post.tagsStr?.split?.(',') ?? [],
);
return { _: true };
},
dismissPostFeedback: async (
Expand Down
Loading