Skip to content

Rules/Languages/hu/unicode-full.yaml: removed unwanted extra rules with possible an another not hungarian branch merge restored - #894

Merged
NSoiffer merged 1 commit into
daisy:mainfrom
hammera:main
Oct 23, 2026
Merged

NSoiffer merged 1 commit into
daisy:mainfrom
hammera:main

Conversation

@hammera

@hammera hammera commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Hi Boys,

@NSoiffer, @moritz-gross, I don't no how happened this, but when I synced my fork the latest upstream main branch this day evening, and after this looked a translator audit tool, I see have 60 extra rules in hungarian files.
The affected file is hungarian unicode-full.yaml file. Possible when the ru branch large merge happened, unfortunatelly restored the 2755 rule number contains hungarian unicode-full.yaml file version, the correct rule number in unicode-full.yaml file is 2714 rules, similar with english unicode-full.yaml file. I am absolute sure known the audit state for example with october 6 PR merge are right, 2714 rules in hungarian unicode-full.yaml.

So, probably sometime after October 20th or October 21st, during a major branch merge, the Hungarian unicode-full.yaml file version was restored to the main branch, which still contained 2755 rules. :-(:-(
I corrected the file, removed the unnecessary extra rules.
I removed from hungarian unicode-full.yaml file again the not need rules (because this rules are already defined into Rules/Languages/hu/unicode.yaml file, similar with english Rules/Languages/en/unicode.yaml file).
Now translator audit tool into the main branch my fork again show following correct summary result, this is the correct result:

│                 SUMMARY                                                      │
│   Files checked                     12                                       │
│   Files with issues                 3                                        │
│   Files OK                          9                                        │
│   Missing rules                     4                                        │
│   Untranslated text                 0                                        │
│   Rule differences                  0                                        │
│   Extra rules                       19                                       │
│   Missing definitions               0                                        │
│   Extra definitions                 0                                        

Now, for example when I look the cat command how many lines contains the english file, the lines number is 3630 lines, the hungarian unicode-full.yaml file contains 3627 lines.

Wrong translator audit summary result, before this PR related commit:

│                 SUMMARY                                                      │
│   Files checked                     12                                       │
│   Files with issues                 4                                        │
│   Files OK                          8                                        │
│   Missing rules                     5                                        │
│   Untranslated text                 0                                        │
│   Rule differences                  0                                        │
│   Extra rules                       60                                       │
│   Missing definitions               0                                        │
│   Definition type mismatches        0                                        │
│   Extra definitions                 0                                        │

Of course I ran cargo build, cargo test commands, and in main branch ran the cargo test Languages::hu commands.
All 637 hungarian tests are correct passed, and all other tests are passed.
Very please merge this change into the main branch to restore right unicode-full.yaml file to the main branch.

Note:
Need still the hu translator branch to always syncing translations both my fork and upstream level, or we delete the hu translation branch?
The hu branch are not refreshed since september 8,, normal rebase to the actual main branch is difficult, because have more merge conflicts, lot of things changed into the main branch.

Attila

…h a previous other branch to main branch merge restored

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@github-actions

Copy link
Copy Markdown
Linux library size: 0.59 MiB (0.00%)
Revision Release liblibmathcat.so
Base (bccc5eb) 0.59 MiB (615,008 bytes)
PR (c196dd6) 0.59 MiB (615,008 bytes)
Change 0 bytes (0.00%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

@hammera

hammera commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Very nice, all checks are passed right.
This PR are mergeable if you would like to the upstream main branch.
I not will be committing other changes with this PR related.

I wish for you a very good weekend,

Attila

@NSoiffer

Copy link
Copy Markdown
Collaborator

Apologies if the mistake was mine (I don't know).

@NSoiffer
NSoiffer merged commit f150745 into daisy:main Oct 23, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Done in MathCAT Project Board Oct 23, 2026
@hammera

hammera commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

@NSoiffer, thanks for merging this PR change with the main branch, now all audit results are perfect again on the latest main branch state (I now synced the branch my fork).
What we doing this similar issue type in release-candidate branch (issue number I think is #889 if I remember correct)?
Yesterday I attached a patch to solve this type issue with release-candidate branch have hungarian unicode-full.yaml file. This issue is more complicated, because not contains the release-candidate branch with importanter october doed translation fixes with main branch already contains.
Because release-candidate branch related not possible doing from my fork a PR, I simple opening the issue #889 and attach all release-candidate branch missing importanter hungarian translation changes.
In the bug description comment attached first unicode-full.yaml file related patch please not use (I little tired and attached previous wrong patch), I corrected this in yesterday evening, other two patches with I attached the bug description is correct (the navigate.yaml file related update patch and the mtable modification and new navigate tests related patch).
If code file modifications not fitting the release-candidate branch policy, enough to applying the hungarian unicode-full.yaml file related modification and hungarian navigate.yaml file related modification the release-candidate branch.
Since I don't know how often the release-candidate branch will be updated, or at what intervals the release-candidate branch will be updated from the entire main branch, I have pulled these changes from the main branch, which have already been merged into the main branch, into the release-candidate branch and attached them to the bug report. :-):-)

Attila

Attila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants