Repository navigation
Rules/Languages/hu/unicode-full.yaml: removed unwanted extra rules with possible an another not hungarian branch merge restored - #894
Conversation
…h a previous other branch to main branch merge restored Signed-off-by: Attila Hammer <hammera@pickup.hu>
Linux library size: 0.59 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
|
Very nice, all checks are passed right. I wish for you a very good weekend, Attila |
|
Apologies if the mistake was mine (I don't know). |
|
@NSoiffer, thanks for merging this PR change with the main branch, now all audit results are perfect again on the latest main branch state (I now synced the branch my fork). Attila Attila |
Hi Boys,
@NSoiffer, @moritz-gross, I don't no how happened this, but when I synced my fork the latest upstream main branch this day evening, and after this looked a translator audit tool, I see have 60 extra rules in hungarian files.
The affected file is hungarian unicode-full.yaml file. Possible when the ru branch large merge happened, unfortunatelly restored the 2755 rule number contains hungarian unicode-full.yaml file version, the correct rule number in unicode-full.yaml file is 2714 rules, similar with english unicode-full.yaml file. I am absolute sure known the audit state for example with october 6 PR merge are right, 2714 rules in hungarian unicode-full.yaml.
So, probably sometime after October 20th or October 21st, during a major branch merge, the Hungarian unicode-full.yaml file version was restored to the main branch, which still contained 2755 rules. :-(:-(
I corrected the file, removed the unnecessary extra rules.
I removed from hungarian unicode-full.yaml file again the not need rules (because this rules are already defined into Rules/Languages/hu/unicode.yaml file, similar with english Rules/Languages/en/unicode.yaml file).
Now translator audit tool into the main branch my fork again show following correct summary result, this is the correct result:
Now, for example when I look the cat command how many lines contains the english file, the lines number is 3630 lines, the hungarian unicode-full.yaml file contains 3627 lines.
Wrong translator audit summary result, before this PR related commit:
Of course I ran cargo build, cargo test commands, and in main branch ran the cargo test Languages::hu commands.
All 637 hungarian tests are correct passed, and all other tests are passed.
Very please merge this change into the main branch to restore right unicode-full.yaml file to the main branch.
Note:
Need still the hu translator branch to always syncing translations both my fork and upstream level, or we delete the hu translation branch?
The hu branch are not refreshed since september 8,, normal rebase to the actual main branch is difficult, because have more merge conflicts, lot of things changed into the main branch.
Attila