Repository navigation
Rename is_valid to is_empty in speech.rs - #899
Closed
moritz-gross wants to merge 1 commit into
Closed
moritz-gross wants to merge 1 commit into
moritz-gross wants to merge 1 commit into
Conversation
Linux library size: 0.59 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
Collaborator
|
I don't like this change. The two functions form a pair. The real issue is that is_valid() is backwards (should return I'm closing this. If you want to do the bigger renaming, open a new PR. |
Collaborator
Author
|
ok then do you fix the naming in a way that makes sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while browsing speech.rs, I found this function name.
Being valid and empty should be semantically different imo, so I changed the name to just mirror
is_empty.