Skip to content

simplify conditions for escape_string_for_safety #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NSoiffer merged 1 commit into from
Oct 24, 2026
+2 −3
Merged

simplify conditions for escape_string_for_safety #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/speech.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2855,9 +2855,8 @@ impl<'c, 's:'c, 'r, 'm:'c> SpeechRulesWithContext<'c, 's,'m> {
}
self.translate_count = 0; // not in loop
// debug!("*** Did not find unicode {} for char '{}'/{:#06x}", rules.name, ch, ch_as_u32);
if rules.translate_single_chars_only || ch.is_ascii() { // speech or if braille, avoid loop (ASCII remains ASCII if not found)
return Ok(self.escape_string_for_safety(String::from(ch)));
} else if ('\u{2800}'..='\u{28ff}').contains(&ch) { // braille -- leave as braille
if rules.translate_single_chars_only || ch.is_ascii() || // speech or if braille, avoid loop (ASCII remains ASCII if not found)
('\u{2800}'..='\u{28ff}').contains(&ch) { // braille -- leave as braille
return Ok(self.escape_string_for_safety(String::from(ch)));
} else { // Emulate what NVDA does: generate (including single quotes) '\xhhhh' or '\yhhhhhh'
let prefix_indicator = if ch_as_u32 < 1<<16 {'x'} else {'y'};
Expand Down
Loading