Fix angle bracket handling#304
Merged
Merged
Conversation
danmactough
force-pushed
the
angle-brackets
branch
from
f01a140 to
b8e2b69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #165
Values for
meta.title,meta.descriptionanditem.titleshould be stripped of HTML tags, but not angle brackets that aren't HTML tags. So,<span>lemon</span>should become "lemon", and<<<Nonsense>>>should remain as-is.This replaces the very naive and incorrect
stripHtmlhelper with a stateful parser to strip HTML tags, HTML comments and declarations, and XML processing instructions without stripping all angle brackets. It was clearly not well thought-out before, but this was the behavior we expectedstripHtml.