Skip to content

avoid progress-related hot spot in ValueFlowPassRunner::run() #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firewave wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

avoid progress-related hot spot in ValueFlowPassRunner::run() #8369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7214,12 +7214,15 @@ struct ValueFlowPassRunner {
{
std::size_t values = 0;
std::size_t n = state.settings.vfOptions.maxIterations;
const bool doProgress = state.settings.reportProgress >= 0;
while (n > 0 && values != getTotalValues()) {
values = getTotalValues();
const std::size_t passnum = state.settings.vfOptions.maxIterations - n + 1;
const std::string passnum_s = std::to_string(passnum);
if (std::any_of(passes.begin(), passes.end(), [&](const ValuePtr<ValueFlowPass>& pass) {
ProgressReporter progressReporter(state.errorLogger, state.settings.reportProgress, state.tokenlist.getSourceFilePath(), std::string("ValueFlow::") + pass->name() + (' ' + passnum_s));
// the string concatination is a hot spot in TestIO::testScanfArgument and TestIO::testPrintfArgumentVariables
std::string stage = doProgress ? std::string("ValueFlow::") + pass->name() + (' ' + passnum_s) : "";
ProgressReporter progressReporter(state.errorLogger, state.settings.reportProgress, state.tokenlist.getSourceFilePath(), std::move(stage));
return run(pass, passnum);
}))
return true;
Expand Down
Loading