feature - implement RFC 022 format functions (#39)#49
Open
dannymeijer wants to merge 8 commits into
Open
Conversation
083dfc2 to
298a26f
Compare
4ebb788 to
c786443
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sha2(...)kept as a compatibility rewrite over concrete SHA-2 helpersinql-datafusion-formatadapter crate; the remaining adapter logic is Incan source using Rust bridge imports only where neededType of change
docs/rfcs/*)Area(s)
Key details
md5,sha1, concrete SHA-2 helpers,sha2,crc32,xxhash64), URL parse/encode/decode helpers, JSON validation/path/schema helpers, and CSV row/schema helpers in scalar projections.src/session/datafusion_format_functions.incnrather than a package-local Rust crate.typeof,is_array, andis_objectremain unavailable until a variant value model exists.0.3.0-rc23, which includes the Rust bridge callback/type-alias fixes needed by the Incan-authored DataFusion UDF bridge.Testing / verification
Verified with Incan
0.3.0-rc23candidate:make fmtgit diff --checkincan test tests/test_hashing_functions.incnincan test tests/test_format_functions.incnincan test tests/test_function_registry.incnincan test tests/test_substrait_plan.incnincan test tests/test_session_projection.incnmake fmt-checkmake test-stylemake registry-metadatamake buildmake build-lockedmake testmake smoke-consumermake pre-commitNote:
make registry-metadatastill prints the knownincan.lock is out of datewarning for its package-root metadata command, but the command passes andmake build-lockedpasses against the refreshed lockfile.Docs impact
Links:
docs/language/reference/functions/format.md,docs/language/reference/functions/index.md,docs/release_notes/v0_1.md,docs/rfcs/022_semi_structured_format_functions.md,docs/rfcs/README.mdStack / Merge Order
Merge after Incan
0.3.0-rc23is available on InQL CI'srelease/v0.3checkout. This PR is full RFC 022 scope and closes #39.Refs #39
Refs dannys-code-corner/incan#708
Refs dannys-code-corner/incan#709