bugfix - preserve expected types for vocab generic calls (#735)#737
Merged
dannymeijer merged 1 commit intoJun 1, 2026
Merged
Conversation
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR preserves contextual expected return types across generic call planning so expression-position vocab desugar output gets the same generic retargeting as equivalent source calls. This fixes DSL-generated calls such as
orders.select(...)inferring the source row model instead of the expected output row model.Type of change
docs/RFCs/*)Area(s)
Select the primary areas touched (used for review routing; labels are managed separately):
Key details
Testing / verification
make test/cargo testmake examples(if relevant)incan fmt --check .(if relevant)Manual verification notes:
cargo test --locked consumer_check_desugared_generic_method_call_uses_expected_return_type_issue735 --test integration_tests -- --nocapturecargo test --locked consumer_check_desugared_public_field_callee_call_typechecks_as_method_issue727 --test integration_tests -- --nocapturecargo test --locked --test cli_integration run_types_rust_callback_closures_in_every_match_arm_issue733 -- --nocapturecargo test --locked -p incan --lib generic_method -- --nocapturecargo fmt --checkgit diff --checkmake pre-commit(full gate, including smoke-test-fast and benchmark build checks)Docs impact
If docs updated:
workspaces/docs-site/docs/release_notes/0_3.mdChecklist
Closes #735