Skip to content

Build the app as jit-snapshot in a from-scratch docker image to reduce dependencies.#9338

Merged
sigurdm merged 15 commits intodart-lang:masterfrom
sigurdm:from_scratch
Apr 16, 2026
Merged

Build the app as jit-snapshot in a from-scratch docker image to reduce dependencies.#9338
sigurdm merged 15 commits intodart-lang:masterfrom
sigurdm:from_scratch

Conversation

@sigurdm
Copy link
Copy Markdown
Contributor

@sigurdm sigurdm commented Apr 10, 2026

  • Create a helper in go for verifying signatures, to remove dependency on an openssl binary.
  • Remove unused dependencies from the docker build script: git, wepb, unzip. They are all only used in the worker.
  • Use kernel snapshots for the search isolates

@sigurdm sigurdm requested review from isoos and jonasfj April 14, 2026 14:26
Comment thread app/bin/server.dart Outdated
Comment thread app/lib/service/entrypoint/search.dart Outdated
spawnUri: Uri.parse(
'package:pub_dev/service/entrypoint/sdk_isolate_index.dart',
),
spawnUri: envConfig.isRunningInAppengine
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe use a separate bool get hasPrecompiledBinaries => isRunningInAppengine flag?

@isoos
Copy link
Copy Markdown
Collaborator

isoos commented Apr 15, 2026

Create a helper in go for verifying signatures, to remove dependency on an openssl binary.

It is not clear if this will be compiled and used locally all the time (in which case let's update the doc/development.md file - which is outdated, but at least add the relevant new tool requirements section).

Use kernel snapshots for the search isolates

It may be worth to have this separately in a different PR.

Co-authored-by: István Soós <isoos@users.noreply.github.com>
@sigurdm
Copy link
Copy Markdown
Contributor Author

sigurdm commented Apr 16, 2026

It is not clear if this will be compiled and used locally all the time (in which case let's update the doc/development.md file - which is outdated, but at least add the relevant new tool requirements section).

It is used all the time. Added a section that you need the go sdk.

Copy link
Copy Markdown
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problems, if istvan is happy :D

Comment thread doc/development.md Outdated
Co-authored-by: István Soós <isoos@users.noreply.github.com>
@sigurdm sigurdm merged commit 6e55713 into dart-lang:master Apr 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants