Skip to content

Add hh model usage parameters#209

Merged
xiong-binbin merged 2 commits into
dashscope:mainfrom
mose-x:support_hh_model_usage
Apr 28, 2026
Merged

Add hh model usage parameters#209
xiong-binbin merged 2 commits into
dashscope:mainfrom
mose-x:support_hh_model_usage

Conversation

@mose-zm
Copy link
Copy Markdown
Contributor

@mose-zm mose-zm commented Apr 28, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the VideoSynthesisUsage class by adding several new fields: ratio, audio, shotType, fps, and referenceType. A review comment suggests changing the fps field from a primitive float to a wrapper Float to better handle optional values and ensure consistency with other fields in the project.

@SerializedName("shot_type")
private String shotType;

private float fps;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a primitive float for the fps field is inconsistent with other optional fields in this project which use wrapper types (e.g., Boolean, Integer). If the fps field is missing in the API response, a primitive float will default to 0.0, which might be misleading. Using Float allows the field to be null if not provided, which is safer for deserialization of optional API response fields.

Suggested change
private float fps;
private Float fps;

@xiong-binbin xiong-binbin merged commit f3b2858 into dashscope:main Apr 28, 2026
3 checks passed
@mose-zm mose-zm deleted the support_hh_model_usage branch May 22, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants