Add hh model usage parameters#209
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the VideoSynthesisUsage class by adding several new fields: ratio, audio, shotType, fps, and referenceType. A review comment suggests changing the fps field from a primitive float to a wrapper Float to better handle optional values and ensure consistency with other fields in the project.
| @SerializedName("shot_type") | ||
| private String shotType; | ||
|
|
||
| private float fps; |
There was a problem hiding this comment.
Using a primitive float for the fps field is inconsistent with other optional fields in this project which use wrapper types (e.g., Boolean, Integer). If the fps field is missing in the API response, a primitive float will default to 0.0, which might be misleading. Using Float allows the field to be null if not provided, which is safer for deserialization of optional API response fields.
| private float fps; | |
| private Float fps; |
No description provided.