Skip to content

fix: raise AttributeError instead of KeyError in __getattr__ #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmSach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: raise AttributeError instead of KeyError in __getattr__ #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dashscope/api_entities/dashscope_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ def setattr(self, attr, value):
return super().__setitem__(attr, value)

def __getattr__(self, attr):
return self[attr]
try:
return self[attr]
except KeyError:
raise AttributeError(attr) from None
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While raising AttributeError correctly fixes the reported issue, the error message could be improved to follow standard Python conventions. Currently, it only provides the attribute name, which results in a terse error like AttributeError: missing_attr. A more descriptive message including the class name (e.g., AttributeError: 'DashScopeAPIResponse' object has no attribute 'missing_attr') would be more helpful for debugging and consistent with built-in Python behavior.

Suggested change
raise AttributeError(attr) from None
raise AttributeError(f"'{type(self).__name__}' object has no attribute '{attr}'") from None


def __setattr__(self, attr, value):
self[attr] = value
Expand Down