Skip to content

sdk/cli: agentic rl#125

Open
lzsweb wants to merge 17 commits into
mainfrom
dev/agentic-rl
Open

sdk/cli: agentic rl#125
lzsweb wants to merge 17 commits into
mainfrom
dev/agentic-rl

Conversation

@lzsweb
Copy link
Copy Markdown
Collaborator

@lzsweb lzsweb commented May 12, 2026

Description

[Describe what this PR does and why]

Related Issue: Fixes #[issue_number] or Relates to #[issue_number]

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Model
  • Application
  • Common
  • Documentation
  • Tests
  • CI/CD

Checklist

  • Pre-commit hooks pass
  • Tests pass locally
  • Documentation updated (if needed)
  • Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive Agentic Reinforcement Learning (RL) framework, including a new AgenticRL client, a Typer-based CLI, and modular components for rollout and reward processing with integrated OpenTelemetry tracing. Key improvements identified in the review include replacing blocking time.sleep() calls with asyncio.sleep() in asynchronous contexts, correcting return type hints for function registration, and avoiding variable shadowing of the zipfile module. Additionally, suggestions were made to optimize memory usage during file uploads by using streaming and to avoid accessing private attributes of the ThreadPoolExecutor.

Comment thread dashscope/finetune/reinforcement/common/model.py Outdated
Comment thread dashscope/finetune/agentic_rl.py Outdated
Comment thread dashscope/finetune/reinforcement/common/model.py Outdated
Comment thread dashscope/finetune/reinforcement/common/utils.py Outdated
Comment thread dashscope/finetune/reinforcement/common/utils.py
Comment thread dashscope/finetune/reinforcement/component/server/server.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant