Add headers to the response.#126
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a headers field to DashScopeAPIResponse and its subclasses to capture HTTP response headers across various API calls. The changes include updates to response initialization, factory methods, and error handling in both synchronous and asynchronous request handlers. Feedback suggests including the headers field in the newly added repr and str methods for completeness and removing redundant type hints in subclasses where the field is already inherited from the base class.
lzsweb
reviewed
May 22, 2026
| message: str | ||
| output: Any | ||
| usage: Any | ||
| headers: dict |
lzsweb
reviewed
May 22, 2026
Collaborator
lzsweb
left a comment
There was a problem hiding this comment.
version.py:version = "1.25.19"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add headers to the response.