fix(workflows): close VEX detection issue when clear and accumulate multi-package CVEs#32
Merged
Merged
Conversation
…ulti-package CVEs Addresses review feedback on microsoft#2038 (@rezatnoMsirhC). - Add a step that closes the dedup detection issue when a later run finds zero untriaged vulnerabilities, so it no longer stays open indefinitely after all CVEs are triaged or suppressed. - Accumulate all affected packages per CVE in the findings table instead of overwriting with the last package, preserving blast-radius visibility. Triage remains per-CVE so VEX correctness is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses @rezatnoMsirhC's two inline review comments on
vex-detect.ymlfrom upstream PR microsoft/hve-core#2038. Once merged to the fork'smain, these commits flow into microsoft#2038.1. Close the detection issue when the backlog clears (bug)
The "File or update detection issue" step is gated
if: count != '' && count != '0', so when a later run finds zero untriaged vulnerabilities the previously-opened dedup issue was never closed — it stayed open indefinitely. Added a companion step (if: count == '0') that finds the open detection issue (same title +automatedsearch the file step uses), comments, and closes it. No new permissions — the job already hasissues: write; the two gates are mutually exclusive.2. Accumulate multi-package CVEs (visibility)
findingsis keyed by CVE id, so when one CVE affected multiple packages the table showed only the last package. Now all affected packages are accumulated (deduped, sorted) into the row, preserving blast-radius visibility. Triage remains per-CVE, so VEX status correctness is unchanged.Validation
actionlintonvex-detect.yml: clean (0 issues).ast.parse).Closes the two review threads; replies posted upstream pointing here.