refactor: Make planner depends on TableContext trait#7600
Merged
mergify[bot] merged 3 commits intoSep 14, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
Bot
added
the
pr-refactor
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
force-pushed
the
make-planner-depends-on-table-context
branch
from
9a1f0b3 to
5a9fda3
Compare
leiysky
reviewed
Sep 14, 2022
zhang2014
approved these changes
Sep 14, 2022
leiysky
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
This PR depends on #7597. Please review after #7597 is merged.
This PR makes the planner depends on the
TableContexttrait instead of theQueryContextstruct.Make space for the future refactor.