Revert vector_search_endpoints UUID persistence (#5127, #5192)#5193
Merged
Conversation
This reverts commit 38eb06e.
…ter out-of-band recreate Adds permissions to the recreated_same_name drift test and asserts that a post-deploy plan shows no changes. Documents that without `endpoint_uuid` in state, the bundle still converges: the first plan after the remote recreate proposes creating permissions on the new endpoint (since state remap returns the live UUID), and a second plan post-deploy shows no permanent drift. Co-authored-by: Isaac
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
May 6, 2026
janniklasrose
added a commit
that referenced
this pull request
May 18, 2026
Main reverted vector_search_endpoints UUID persistence in #5193, so the endpoint plan no longer carries a synthetic endpoint_uuid change to be classified as Skip via OverrideChangeDesc. Regenerate the with_endpoint plan output to match. Co-authored-by: Isaac
denik
pushed a commit
that referenced
this pull request
May 20, 2026
## Summary - Reverts #5127 (`Persist endpoint UUID for vector_search_endpoints drift detection`) and the follow-up changelog entry from #5192. - The badness #5127 was meant to fix — bundle silently rebinding permissions to a different backing endpoint after an out-of-band recreate — was actually addressed by the testserver fix in #5186 (`testserver: 404 on permissions GET when V2 parent is gone`). With the testserver matching real V2 cloud behavior, bundle correctly observes that the new endpoint has no permissions and creates them, with no permanent drift afterwards. UUID persistence in state is no longer necessary. - Reworks the `drift/recreated_same_name` acceptance test: keeps endpoint permissions in `databricks.yml`, drops the obsolete "recreate detected" assertion, and adds a post-deploy `bundle plan` to confirm there is no permanent drift. ## Test plan - [x] `./task build` clean. - [x] `go test ./acceptance -run 'TestAccept/bundle/resources/vector_search_endpoints/drift'` — all green (terraform + direct). - [x] `go test ./bundle/direct/dresources/...` — green. - [x] `./task lint-q` — clean. - [x] Verified post-deploy plan shows `Plan: 0 to add, 0 to change, 0 to delete, 2 unchanged` after an out-of-band endpoint recreate, so permissions don't end up in permanent drift even without UUID-based recreate detection. This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist endpoint UUID for vector_search_endpoints drift detection) and the follow-up changelog entry from Update changelog re 5127 #5192.testserver: 404 on permissions GET when V2 parent is gone). With the testserver matching real V2 cloud behavior, bundle correctly observes that the new endpoint has no permissions and creates them, with no permanent drift afterwards. UUID persistence in state is no longer necessary.drift/recreated_same_nameacceptance test: keeps endpoint permissions indatabricks.yml, drops the obsolete "recreate detected" assertion, and adds a post-deploybundle planto confirm there is no permanent drift.Test plan
./task buildclean.go test ./acceptance -run 'TestAccept/bundle/resources/vector_search_endpoints/drift'— all green (terraform + direct).go test ./bundle/direct/dresources/...— green../task lint-q— clean.Plan: 0 to add, 0 to change, 0 to delete, 2 unchangedafter an out-of-band endpoint recreate, so permissions don't end up in permanent drift even without UUID-based recreate detection.This pull request and its description were written by Isaac.