config-remote-sync: skip permissions/grants sub-resources instead of failing#5979
Open
ilyakuz-db wants to merge 5 commits into
Open
config-remote-sync: skip permissions/grants sub-resources instead of failing#5979ilyakuz-db wants to merge 5 commits into
ilyakuz-db wants to merge 5 commits into
Conversation
Collaborator
Integration test reportCommit: 742d04e
8 interesting tests: 4 RECOVERED, 4 SKIP
|
ilyakuz-db
marked this pull request as ready for review
July 20, 2026 15:58
Contributor
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Syncing permissions back is not yet supported, so these sub-resources are now skipped in
ExtractChangesinstead of failing the whole run.bundle config-remote-sync(used by DABs in the Workspace to write remote resource changes back to YAML) failed the entire sync when a job/pipeline had permissions or grants. These are emitted by the plan as their own sub-resources (resources.<type>.<name>.permissions/.grants), which config-remote-sync cannot write back — the server-populatedobject_idfield has no YAML source location, and bundle-level permissions have no per-resource YAML node at all. This surfaced as eitherfailed to find location for resource ...permissions for a field object_idor a selector-parse crash onpermissions.[user_name='...'].Why
One malformed sub-resource change was aborting the sync for the whole bundle, so users with permissions on any resource could never sync any UI edit back to config.
Tests
Unit test for the skip in
ExtractChanges(both engines) and an acceptance test that reproduces the exact failure without the fix.