[DABs] config-remote-sync: skip stale --select-ids selectors instead of failing the batch#5980
Draft
ilyakuz-db wants to merge 4 commits into
Draft
[DABs] config-remote-sync: skip stale --select-ids selectors instead of failing the batch#5980ilyakuz-db wants to merge 4 commits into
ilyakuz-db wants to merge 4 commits into
Conversation
Collaborator
Integration test reportCommit: 968cd77
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 4 slowest tests (at least 2 minutes):
|
…r matched (avoid false success)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle config-remote-sync --select-ids <type:id>,...is how DABs in the Workspace syncs edited resources — the UI batches every edited resource into one call. Previously, if any one selector matched no deployed resource in state, the command errored withno deployed <type> resource with id <id>and the whole batch failed, dropping the valid resources' edits too.A selector that matches no deployed resource (deleted remotely, or deploy-state drift) is now skipped — a resource with no deployed state has no remote change to pull back into config. A malformed selector (bad
<type>:<id>shape) is still an error.Why
A single stale resource id was causing every sync to fail for the affected workspace, so no UI edit could be written back.
Tests
Extended the
select_basicacceptance test: a batch with one stale selector still syncs the valid resource; an all-stale sync is a clean no-op; a malformed selector is still rejected.