Fix aitools/install panic in TestCountFuzz on agent-equipped machines#5984
Open
pietern wants to merge 1 commit into
Open
Fix aitools/install panic in TestCountFuzz on agent-equipped machines#5984pietern wants to merge 1 commit into
pietern wants to merge 1 commit into
Conversation
TestCountFuzz/aitools/install panics with `telemetry logger not found`, but only on machines with a supported coding agent installed. Two causes: 1. aitools is hand-written but was being fuzzed. It was missing from the fuzz harness manualRoots blocklist added in #5102 (the test targets auto-generated commands, guarding against codegen regressions like #5070). 2. telemetry.Log panicked when no logger was on the context, which aitools install started triggering in #5862 (telemetry for the command). CI never caught it: install's deferred logInstallEvent only runs once an agent is detected, and the panic is unreachable via the real CLI anyway (cmd/root.Execute always installs the logger; the fuzz harness bypasses it). Co-authored-by: Isaac
Contributor
Approval status: pending
|
pietern
enabled auto-merge
July 20, 2026 12:59
Collaborator
Integration test reportCommit: 93de39f
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 5 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCountFuzz/aitools/installpanics withtelemetry logger not found, but only on machines with a supported coding agent installed.Two causes:
aitoolsis hand-written but was being fuzzed. It was missing from the fuzz harnessmanualRootsblocklist added in cmd: add count-fuzz test for auto-generated commands #5102 (the test targets auto-generated commands, guarding against codegen regressions like CLI panics on interactive command for warehouses update-default-warehouse-override #5070).telemetry.Logpanicked when no logger was on the context, whichaitools installstarted triggering in Add telemetry fordatabricks aitools install#5862 (telemetry for the command).CI never caught it:
install's deferredlogInstallEventonly runs once an agent is detected, and the panic is unreachable via the real CLI anyway (cmd/root.Executealways installs the logger; the fuzz harness bypasses it).This pull request and its description were written by Isaac.