Improved usability of `databricks auth login ... --configure-cluster` flow by displaying cluster type and runtime version by nfx · Pull Request #956 · databricks/cli

nfx · 2023-11-06T20:32:39Z

This PR adds selectors for Databricks-connect compatible clusters and SQL warehouses

Tested in #914

pietern

As utility functions these belong under the libs package, IMO.

pietern

You moved this to databrickscfg, but how is this related?

These are pickers, so what about libs/pickers?

nfx · 2023-11-09T11:14:49Z

@pietern this is in databrickscfg, because cluster_id / warehouse_id is in ~/.databrickscfg.

pietern

How is that related? They use zero common code.

nfx · 2023-11-09T11:53:17Z

@pietern it is related. see go/sdk/config/cluster

nfx · 2023-11-09T12:16:13Z

@pietern check go/sdk/config/cluster, ec75364 and tell if we still want to have libs/pickers

pietern

LGTM, thanks.

I noticed one functional change -- when running auth login, and there being only a single compatible cluster, the user no longer sees a prompt. That misses out on a bit of educational value, and may have unintended consequences (i.e. not knowing that the profile has a cluster attached, and running stuff remotely inadvertently).

This release includes the new `databricks labs` command to install, manage, and run Databricks Labs projects. CLI: * Add `--debug` as shortcut for `--log-level debug` ([#964](#964)). * Improved usability of `databricks auth login ... --configure-cluster` ([#956](#956)). * Make `databricks configure` save only explicit fields ([#973](#973)). * Add `databricks labs` command group ([#914](#914)). * Tolerate missing .databrickscfg file during `databricks auth login` ([#1003](#1003)). * Add `--configure-cluster` flag to configure command ([#1005](#1005)). * Fix bug where the account or workspace client could be `nil` ([#1020](#1020)). Bundles: * Do not allow empty descriptions for bundle template inputs ([#967](#967)). * Added support for top-level permissions ([#928](#928)). * Allow jobs to be manually unpaused in development mode ([#885](#885)). * Fix template initialization from current working directory ([#976](#976)). * Add `--tag` and `--branch` options to bundle init command ([#975](#975)). * Work around DLT issue with `$PYTHONPATH` not being set correctly ([#999](#999)). * Enable `spark_jar_task` with local JAR libraries ([#993](#993)). * Pass `USERPROFILE` environment variable to Terraform ([#1001](#1001)). * Improve error message when path is not a bundle template ([#985](#985)). * Correctly overwrite local state if remote state is newer ([#1008](#1008)). * Add mlops-stacks to the default `databricks bundle init` prompt ([#988](#988)). * Do not add wheel content hash in uploaded Python wheel path ([#1015](#1015)). * Do not replace pipeline libraries if there are no matches for pattern ([#1021](#1021)). Internal: * Update CLI version in the VS Code extension during release ([#1014](#1014)). API Changes: * Changed `databricks functions create` command . New request type is . * Changed `databricks metastores create` command with new required argument order. * Removed `databricks metastores enable-optimization` command. * Removed `databricks account o-auth-enrollment` command group. * Removed `databricks apps delete` command. * Removed `databricks apps get` command. * Added `databricks apps delete-app` command. * Added `databricks apps get-app` command. * Added `databricks apps get-app-deployment-status` command. * Added `databricks apps get-apps` command. * Added `databricks apps get-events` command. * Added `databricks account network-connectivity` command group. OpenAPI commit 22f09783eb8a84d52026f856be3b2068f9498db3 (2023-11-23) Dependency updates: * Bump golang.org/x/term from 0.13.0 to 0.14.0 ([#981](#981)). * Bump github.com/hashicorp/terraform-json from 0.17.1 to 0.18.0 ([#979](#979)). * Bump golang.org/x/oauth2 from 0.13.0 to 0.14.0 ([#982](#982)). * Bump github.com/databricks/databricks-sdk-go from 0.24.0 to 0.25.0 ([#980](#980)). * Bump github.com/databricks/databricks-sdk-go from 0.25.0 to 0.26.0 ([#1019](#1019)).

This release includes the new `databricks labs` command to install, manage, and run Databricks Labs projects. CLI: * Add `--debug` as shortcut for `--log-level debug` ([#964](#964)). * Improved usability of `databricks auth login ... --configure-cluster` ([#956](#956)). * Make `databricks configure` save only explicit fields ([#973](#973)). * Add `databricks labs` command group ([#914](#914)). * Tolerate missing .databrickscfg file during `databricks auth login` ([#1003](#1003)). * Add `--configure-cluster` flag to configure command ([#1005](#1005)). * Fix bug where the account or workspace client could be `nil` ([#1020](#1020)). Bundles: * Do not allow empty descriptions for bundle template inputs ([#967](#967)). * Added support for top-level permissions ([#928](#928)). * Allow jobs to be manually unpaused in development mode ([#885](#885)). * Fix template initialization from current working directory ([#976](#976)). * Add `--tag` and `--branch` options to bundle init command ([#975](#975)). * Work around DLT issue with `$PYTHONPATH` not being set correctly ([#999](#999)). * Enable `spark_jar_task` with local JAR libraries ([#993](#993)). * Pass `USERPROFILE` environment variable to Terraform ([#1001](#1001)). * Improve error message when path is not a bundle template ([#985](#985)). * Correctly overwrite local state if remote state is newer ([#1008](#1008)). * Add mlops-stacks to the default `databricks bundle init` prompt ([#988](#988)). * Do not add wheel content hash in uploaded Python wheel path ([#1015](#1015)). * Do not replace pipeline libraries if there are no matches for pattern ([#1021](#1021)). Internal: * Update CLI version in the VS Code extension during release ([#1014](#1014)). API Changes: * Changed `databricks functions create` command. * Changed `databricks metastores create` command with new required argument order. * Removed `databricks metastores enable-optimization` command. * Removed `databricks account o-auth-enrollment` command group. * Removed `databricks apps delete` command. * Removed `databricks apps get` command. * Added `databricks apps delete-app` command. * Added `databricks apps get-app` command. * Added `databricks apps get-app-deployment-status` command. * Added `databricks apps get-apps` command. * Added `databricks apps get-events` command. * Added `databricks account network-connectivity` command group. OpenAPI commit 22f09783eb8a84d52026f856be3b2068f9498db3 (2023-11-23) Dependency updates: * Bump golang.org/x/term from 0.13.0 to 0.14.0 ([#981](#981)). * Bump github.com/hashicorp/terraform-json from 0.17.1 to 0.18.0 ([#979](#979)). * Bump golang.org/x/oauth2 from 0.13.0 to 0.14.0 ([#982](#982)). * Bump github.com/databricks/databricks-sdk-go from 0.24.0 to 0.25.0 ([#980](#980)). * Bump github.com/databricks/databricks-sdk-go from 0.25.0 to 0.26.0 ([#1019](#1019)).

…5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in #4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in #956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.

… flow by displaying cluster type and runtime version (#956) This PR adds selectors for Databricks-connect compatible clusters and SQL warehouses Tested in #914

This release includes the new `databricks labs` command to install, manage, and run Databricks Labs projects. CLI: * Add `--debug` as shortcut for `--log-level debug` ([#964](#964)). * Improved usability of `databricks auth login ... --configure-cluster` ([#956](#956)). * Make `databricks configure` save only explicit fields ([#973](#973)). * Add `databricks labs` command group ([#914](#914)). * Tolerate missing .databrickscfg file during `databricks auth login` ([#1003](#1003)). * Add `--configure-cluster` flag to configure command ([#1005](#1005)). * Fix bug where the account or workspace client could be `nil` ([#1020](#1020)). Bundles: * Do not allow empty descriptions for bundle template inputs ([#967](#967)). * Added support for top-level permissions ([#928](#928)). * Allow jobs to be manually unpaused in development mode ([#885](#885)). * Fix template initialization from current working directory ([#976](#976)). * Add `--tag` and `--branch` options to bundle init command ([#975](#975)). * Work around DLT issue with `$PYTHONPATH` not being set correctly ([#999](#999)). * Enable `spark_jar_task` with local JAR libraries ([#993](#993)). * Pass `USERPROFILE` environment variable to Terraform ([#1001](#1001)). * Improve error message when path is not a bundle template ([#985](#985)). * Correctly overwrite local state if remote state is newer ([#1008](#1008)). * Add mlops-stacks to the default `databricks bundle init` prompt ([#988](#988)). * Do not add wheel content hash in uploaded Python wheel path ([#1015](#1015)). * Do not replace pipeline libraries if there are no matches for pattern ([#1021](#1021)). Internal: * Update CLI version in the VS Code extension during release ([#1014](#1014)). API Changes: * Changed `databricks functions create` command. * Changed `databricks metastores create` command with new required argument order. * Removed `databricks metastores enable-optimization` command. * Removed `databricks account o-auth-enrollment` command group. * Removed `databricks apps delete` command. * Removed `databricks apps get` command. * Added `databricks apps delete-app` command. * Added `databricks apps get-app` command. * Added `databricks apps get-app-deployment-status` command. * Added `databricks apps get-apps` command. * Added `databricks apps get-events` command. * Added `databricks account network-connectivity` command group. OpenAPI commit 22f09783eb8a84d52026f856be3b2068f9498db3 (2023-11-23) Dependency updates: * Bump golang.org/x/term from 0.13.0 to 0.14.0 ([#981](#981)). * Bump github.com/hashicorp/terraform-json from 0.17.1 to 0.18.0 ([#979](#979)). * Bump golang.org/x/oauth2 from 0.13.0 to 0.14.0 ([#982](#982)). * Bump github.com/databricks/databricks-sdk-go from 0.24.0 to 0.25.0 ([#980](#980)). * Bump github.com/databricks/databricks-sdk-go from 0.25.0 to 0.26.0 ([#1019](#1019)).

…5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in #4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in #956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.

…atabricks#5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in databricks#4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in databricks#956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.

Expose selectors for UC clusters and SQL warehouses

802cb51

nfx requested a review from pietern November 6, 2023 20:32

This was referenced Nov 6, 2023

Make Cobra runner compatible with testing interactive flows #957

Merged

Add databricks labs command group #914

Merged

nfx added the CLI CLI related issues label Nov 7, 2023

nfx enabled auto-merge November 7, 2023 23:58

pietern reviewed Nov 8, 2023

View reviewed changes

Comment thread cmd/workspace/clusters/uc.go Outdated

Comment thread cmd/workspace/clusters/uc.go

..

aef6541

nfx requested a review from pietern November 8, 2023 16:24

pietern reviewed Nov 9, 2023

View reviewed changes

nfx requested a review from pietern November 9, 2023 11:14

pietern reviewed Nov 9, 2023

View reviewed changes

..

ec75364

nfx requested a review from pietern November 9, 2023 12:16

Serge Smertin added 3 commits November 9, 2023 13:41

added support for snapshots

12cc8f0

added cfg pickers

9c01b2d

..

09b142e

nfx changed the title ~~Expose selectors for UC clusters and SQL warehouses~~ Improved usability of databricks auth login ... --configure-cluster flow by displaying cluster type and runtime version Nov 9, 2023

pietern reviewed Nov 9, 2023

View reviewed changes

Comment thread libs/databrickscfg/cfgpickers/clusters.go Outdated

Comment thread libs/databrickscfg/profiles.go Outdated

..

0baccd7

nfx requested a review from pietern November 9, 2023 16:32

pietern approved these changes Nov 9, 2023

View reviewed changes

nfx added this pull request to the merge queue Nov 9, 2023

Merged via the queue into main with commit 3284a8c Nov 9, 2023

nfx deleted the compatible/clusters branch November 9, 2023 16:47

pietern mentioned this pull request Nov 29, 2023

Release v0.210.0 #1023

Merged

pietern mentioned this pull request May 4, 2026

Remove no-op promptui.SearchPrompt assignment in warehouse picker #5168

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved usability of `databricks auth login ... --configure-cluster` flow by displaying cluster type and runtime version#956

Improved usability of `databricks auth login ... --configure-cluster` flow by displaying cluster type and runtime version#956
nfx merged 7 commits into
mainfrom
compatible/clusters

nfx commented Nov 6, 2023 •

edited

Loading

Uh oh!

pietern left a comment

Uh oh!

Uh oh!

Uh oh!

pietern left a comment

Uh oh!

nfx commented Nov 9, 2023 •

edited

Loading

Uh oh!

pietern left a comment

Uh oh!

nfx commented Nov 9, 2023

Uh oh!

nfx commented Nov 9, 2023

Uh oh!

Uh oh!

Uh oh!

pietern left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nfx commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pietern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pietern left a comment

Choose a reason for hiding this comment

Uh oh!

nfx commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pietern left a comment

Choose a reason for hiding this comment

Uh oh!

nfx commented Nov 9, 2023

Uh oh!

nfx commented Nov 9, 2023

Uh oh!

Uh oh!

Uh oh!

pietern left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nfx commented Nov 6, 2023 •

edited

Loading

nfx commented Nov 9, 2023 •

edited

Loading