Add enforceEmbeddedSchemaCorrectness to TExecuteStatementReq#344
Open
Add enforceEmbeddedSchemaCorrectness to TExecuteStatementReq#344
Conversation
Add a new optional bool field (0xD19) to TExecuteStatementReq in the thrift contract and expose it as an opt-in configuration parameter. When enabled, the server enforces embedded schema correctness during query execution. - Add field to thrift-generated cli_service.go with full Read/Write/Equals support - Add EnforceEmbeddedSchemaCorrectness to UserConfig (default false) - Add WithEnforceEmbeddedSchemaCorrectness connector option - Add DSN parameter support (enforceEmbeddedSchemaCorrectness=true) - Wire config to TExecuteStatementReq in executeStatement ES-1804970 Co-authored-by: Isaac
samikshya-db
reviewed
Apr 6, 2026
| return p.StatementConf | ||
| } | ||
| var TExecuteStatementReq_EnforceEmbeddedSchemaCorrectness_DEFAULT bool | ||
| func (p *TExecuteStatementReq) GetEnforceEmbeddedSchemaCorrectness() bool { |
Collaborator
There was a problem hiding this comment.
Was this manually added and not by thrift command?
Collaborator
There was a problem hiding this comment.
+1, let's make sure this was added by the thrift cli
vikrantpuppala
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enforceEmbeddedSchemaCorrectness(field ID0xD19/ 3353) toTExecuteStatementReqin the thrift contractEnforceEmbeddedSchemaCorrectness, defaultfalse) via connector option, DSN parameter, and config structtrue), the field is set in the thrift request so the server enforces embedded schema correctness during query executionChanges
internal/cli_service/cli_service.go— Added field with full Read/Write/IsSet/Equals support following existing*boolpointer patterninternal/config/config.go— AddedEnforceEmbeddedSchemaCorrectnesstoUserConfig+ DSN parsingconnector.go— AddedWithEnforceEmbeddedSchemaCorrectness()connector optionconnection.go— Wired config toTExecuteStatementReqinexecuteStatement()Test plan
enforceEmbeddedSchemaCorrectness=truein DSNWithEnforceEmbeddedSchemaCorrectness(true)connector optionResolves: ES-1804970
This pull request was AI-assisted by Isaac.