Skip to content

perf: abstract FormatCache as pluggable trait, optimize format runtime #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenamar-db merged 1 commit into from
Apr 8, 2026
Merged

perf: abstract FormatCache as pluggable trait, optimize format runtime #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sjsonnet/src-jvm-native/sjsonnet/SjsonnetMainBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,8 @@ object SjsonnetMainBase {
logger = warnLogger,
std = std,
variableResolver = _ => None,
debugStats = debugStats
debugStats = debugStats,
formatCache = FormatCache.SharedDefault
) {
override def createEvaluator(
resolver: CachedResolver,
Expand Down
8 changes: 5 additions & 3 deletions sjsonnet/src/sjsonnet/Evaluator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ class Evaluator(
val wd: Path,
val settings: Settings,
logger: Evaluator.Logger = null,
val debugStats: DebugStats = null)
val debugStats: DebugStats = null,
override val formatCache: FormatCache = FormatCache.SharedDefault)
extends EvalScope {
implicit def evalScope: EvalScope = this
def importer: CachedImporter = resolver
Expand Down Expand Up @@ -1256,8 +1257,9 @@ class NewEvaluator(
private val w: Path,
private val s: Settings,
private val wa: Evaluator.Logger = null,
ds: DebugStats = null)
extends Evaluator(r, e, w, s, wa, ds) {
ds: DebugStats = null,
fc: FormatCache = FormatCache.SharedDefault)
extends Evaluator(r, e, w, s, wa, ds, fc) {

override def visitExpr(e: Expr)(implicit scope: ValScope): Val = try {
(e.tag: @switch) match {
Expand Down
Loading