Refactor measurement dimensions handling in configuration and related…#33
Merged
Merged
Conversation
… components - Updated `ImpulseConfig` to accept a list of silver-layer `container_metrics` column names for `measurement_dimensions`, replacing the previous enum-based approach. - Enhanced documentation to clarify the behavior of `measurement_dimensions`, including the removal of automatic injection of `container_id`. - Introduced properties in `SolverConfig` for `start_ts` and `stop_ts` to facilitate easier access to internal timestamp column names. - Modified `ContainerDimension` to validate the presence of configured measurement dimensions in the silver `container_metrics` table, raising errors for missing columns. - Updated tests to ensure correct behavior with the new configuration structure and to validate the handling of custom timestamp column mappings. - Adjusted integration tests to reflect changes in measurement dimension handling and ensure compatibility with the updated configuration.
- Updated `configuration.md` to clarify the purpose of `tstart` and `tend` in the `channels` table. - Added detailed sections in `silver_layer_schema.md` to document internal columns referenced by the framework across `container_metrics`, `container_tags`, `channel_metrics`, and `channel_tags`. - Improved clarity on how to map silver columns to internal names using `solver_config` for better integration and understanding of the data model.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
- Coverage 86.28% 86.24% -0.04%
==========================================
Files 52 52
Lines 4177 4166 -11
Branches 498 499 +1
==========================================
- Hits 3604 3593 -11
Misses 477 477
Partials 96 96
🚀 New features to boost your workflow:
|
MaximHammer
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… components
ImpulseConfigto accept a list of silver-layercontainer_metricscolumn names formeasurement_dimensions, replacing the previous enum-based approach.measurement_dimensions, including the removal of automatic injection ofcontainer_id.SolverConfigforstart_tsandstop_tsto facilitate easier access to internal timestamp column names.ContainerDimensionto validate the presence of configured measurement dimensions in the silvercontainer_metricstable, raising errors for missing columns.Summary
Changes
Test Plan
Checklist