Upgrade: Rails 7.2 → 8.1 & Ruby 3.2.9 → 4.0.1#1506
Open
Conversation
kaysiz
changed the title
|
|
||
| # Logger configuration - uses LogStashLogger (structured JSON logging) | ||
| # Rails.logger and Rails.application.config.lograge.logger are the same instance | ||
| config.logger = Rails.logger |
Contributor
There was a problem hiding this comment.
What's the removal of this for? I think this was in place as per the comment to use same setup for Rails with sentry, did something change in a gem?
Member
Author
There was a problem hiding this comment.
The gem does not have logger attribute anymore.
Contributor
There was a problem hiding this comment.
Hmm okay, then I guess we need to check it integrates okay on staging.
richardhallett
approved these changes
Apr 13, 2026
Contributor
richardhallett
left a comment
richardhallett
left a comment
There was a problem hiding this comment.
Lots of files changed but mostly seem similiar so I think fine.
Once merged we'll need to do some testing but PR itself looks okay to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: