Who Treatment Outcome TB and HIV#1937
Open
HarishC727 wants to merge 7 commits intodatacommonsorg:masterfrom
Open
Who Treatment Outcome TB and HIV#1937HarishC727 wants to merge 7 commits intodatacommonsorg:masterfrom
HarishC727 wants to merge 7 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new statvar import for WHO Tuberculosis treatment outcomes among people living with HIV, including a data download script, manifest, and mapping files. The reviewer feedback highlights a redundant network request in the Python script, incorrect indicator URLs in the documentation and manifest, and several formatting issues such as trailing spaces and missing trailing newlines across multiple files.
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/tb_data_download_who.py
Outdated
Show resolved
Hide resolved
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/metadata.csv
Outdated
Show resolved
Hide resolved
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/tb_data_download_who.py
Show resolved
Hide resolved
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/tuberculosis_outcome_pvmap.csv
Outdated
Show resolved
Hide resolved
saanikaaa
reviewed
Mar 30, 2026
statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/manifest.json
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Done
…On Mon, Mar 30, 2026 at 4:35 PM saanikaaa ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In statvar_imports/who_tuberculosis/treatmentoutcome_tb_hiv/manifest.json
<#1937?email_source=notifications&email_token=AYOEZNQ2UDL5N3GFIYO4B3T4TJIINA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSHE3TOMBSGM3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K64DSL5ZGK5TJMV3V6Y3MNFRWW#discussion_r3009088501>
:
> @@ -0,0 +1,26 @@
+{
+ "import_specifications": [
+ {
+ "import_name": "TreatmentOutcome_TB_HIV",
Pls rectify as latest changes
—
Reply to this email directly, view it on GitHub
<#1937?email_source=notifications&email_token=AYOEZNWOXHYQ2ZEUBIMA6SL4TJIINA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBSHE3TOMBSGM3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2L24DSL5ZGK5TJMV3V63TPORUWM2LDMF2GS33OONPWG3DJMNVQ#pullrequestreview-4029770236>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYOEZNQEAPJX63FKRIM6TTD4TJIINAVCNFSM6AAAAACXBSRHCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMRZG43TAMRTGY>
.
You are receiving this because you authored the thread.Message ID:
<datacommonsorg/data/pull/1937/review/4029770236 ***@***.***
.com>
|
saanikaaa
approved these changes
Mar 30, 2026
vish-cs
reviewed
Apr 13, 2026
| @@ -0,0 +1,26 @@ | |||
| # WHO Treatment Outcome for TB and HIV | |||
|
|
|||
| - source: https://data.who.int/indicators/i/DCDC2EB/625E736 | |||
Contributor
There was a problem hiding this comment.
Can we add more description about the dataset?
Contributor
Author
There was a problem hiding this comment.
added description
| "source_files": [ | ||
| "input_files/Tuberculosis_outcome_TB_HIV.csv" | ||
| ], | ||
| "cron_schedule": "0 10 10 * *" |
Contributor
There was a problem hiding this comment.
Why the schedule is set to daily?
Contributor
Author
There was a problem hiding this comment.
This is set as to run on 10th of every month.
Changed it to run twice in a month to avoid confusion
vish-cs
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist