Skip to content

Ingestion pipeline imports #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwnoble wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ingestion pipeline imports #491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b116a
readme updates
dwnoble Mar 24, 2026
5599788
updated readme
dwnoble Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pipeline/ingestion/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,19 @@ The pipeline is configured using `IngestionPipelineOptions`. Key options include

## Example Usage

To run the pipeline locally using the Direct runner:
First, ensure all dependencies are installed locally. After cloning the `datacommons/import` repository, run the following command from the project's root directory:

```bash
mvn clean install
```

To run the pipeline locally using the Direct runner, cd to the `pipeline/ingestion` directory and run:
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding the instruction to cd into the pipeline/ingestion directory is a good clarification, the mvn command that follows will likely fail when executed from this location. The -pl ingestion -am flags are intended for use when running Maven from a parent directory of the ingestion module, not from within the module directory itself. To fix this, you should either remove the -pl ingestion -am flags from the command or, alternatively, instruct the user to run the command from the project root and adjust the path in the -pl flag (e.g., -pl pipeline/ingestion).


```bash
mvn -Pdirect-runner compile exec:java \
-pl ingestion -am \
-Dexec.mainClass=org.datacommons.ingestion.pipeline.GraphIngestionPipeline \
-Dexec.args="--project=YOUR_PROJECT_ID \
-Dexec.args="--projectId=YOUR_PROJECT_ID \
--spannerInstanceId=YOUR_INSTANCE_ID \
--spannerDatabaseId=YOUR_DATABASE_ID \
--importList='[{\"importName\": \"Schema\", \"graphPath\": \"gs://path/to/schema/mcf/\"}, {\"importName\": \"SampleImport\", \"graphPath\": \"gs://path/to/data.tfrecord\"}]' \
Expand All @@ -49,7 +55,7 @@ To run the pipeline using the Dataflow runner:
mvn -Pdataflow-runner compile exec:java \
-pl ingestion -am \
-Dexec.mainClass=org.datacommons.ingestion.pipeline.GraphIngestionPipeline \
-Dexec.args="--project=YOUR_PROJECT_ID \
-Dexec.args="--projectId=YOUR_PROJECT_ID \
--spannerInstanceId=YOUR_INSTANCE_ID \
--spannerDatabaseId=YOUR_DATABASE_ID \
--importList='[{\"importName\": \"Schema\", \"graphPath\": \"gs://path/to/schema/mcf/\"}, {\"importName\": \"SampleImport\", \"graphPath\": \"gs://path/to/data.tfrecord\"}]' \
Expand Down