Add configuration to control spanner graph search#1841
Add configuration to control spanner graph search#1841shixiao-coder wants to merge 8 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new data structures and constants for Spanner search configurations, including search algorithms, graph configurations, and embedding settings. The review feedback suggests several improvements for clarity and naming consistency: renaming GraphConfig to GraphSearchMode to better reflect its purpose as a strategy, clarifying the EmbeddingSpace field (potentially to EmbeddingDimension) to reduce ambiguity, and ensuring field names do not conflict with their type names.
n-h-diaz
left a comment
n-h-diaz
left a comment
There was a problem hiding this comment.
Thanks! This seems fine to me, but I have less context on how this will be used, so would be good if Christie or Keyur could also take a look
1) It adds descriptions to the enums 2) It adds Yaml files to read configurations 3) It adds the function to read the Yaml and Convert to Configuration structure
clincoln8
left a comment
clincoln8
left a comment
There was a problem hiding this comment.
Thanks! Just some nits and clarification requests.
3 participants
This is the first PR to add Graph Search functionality into v2/resolve. It will add a configuration structure to tune search