-
Notifications
You must be signed in to change notification settings - Fork 122
[Service Health] CDC Autopush tagged for Service Health #6148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
98f7114
Tags the CDC autopush deploy properly.
gmechali b050649
Merge branch 'datacommonsorg:master' into cdctags
gmechali 96c1bb0
Fix
gmechali 84dd45d
Merge branch 'master' into cdctags
gmechali 2140235
Apply suggestions from code review
gmechali 4610954
Fix gemini comments
gmechali d98fe85
Merge branch 'cdctags' of https://github.com/gmechali/website into cd…
gmechali 73f73c3
Merge branch 'master' into cdctags
gmechali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| steps: | ||
| - name: 'gcr.io/google.com/cloudsdktool/cloud-sdk' | ||
| entrypoint: 'gcloud' | ||
| args: | ||
| - 'run' | ||
| - 'deploy' | ||
| - 'dc-autopush' | ||
| - '--project' | ||
| - 'datcom-website-dev' | ||
| - '--image' | ||
| - 'gcr.io/datcom-ci/datacommons-services:latest' | ||
| - '--region' | ||
| - 'us-central1' | ||
| - '--update-env-vars' | ||
| - 'RESTART_TIMESTAMP=$BUILD_ID' | ||
|
|
||
| tags: | ||
| - 'cloudrun--dc-autopush' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the Cloud Build substitution syntax
${BUILD_ID}to ensure the variable is expanded by the Cloud Build service. Since thegcloudentrypoint does not invoke a shell to process arguments, using$BUILD_IDwill result in the literal string "$BUILD_ID" being set as the environment variable value in Cloud Run, which breaks the intended audit functionality.- 'RESTART_TIMESTAMP=${BUILD_ID}'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.