Skip to content

Fix setup interactivity and Python requirement alignment#420

Open
qianhaoq wants to merge 3 commits into
dataelement:mainfrom
qianhaoq:fix-setup-wecom-startup
Open

Fix setup interactivity and Python requirement alignment#420
qianhaoq wants to merge 3 commits into
dataelement:mainfrom
qianhaoq:fix-setup-wecom-startup

Conversation

@qianhaoq

@qianhaoq qianhaoq commented Apr 15, 2026

Copy link
Copy Markdown

Summary

  • make setup.sh use non-interactive PostgreSQL client checks so existing password-protected PostgreSQL installs do not hang on a prompt
  • improve the virtualenv failure message for Ubuntu/Debian environments missing python3.12-venv
  • align backend packaging metadata with the setup script by requiring Python 3.12
  • document the python3.12-venv prerequisite in the English and Chinese READMEs

Verification

  • bash -n setup.sh
  • confirmed backend/pyproject.toml now requires Python >=3.12

Notes

  • merged the latest main into this branch so the PR no longer carries the WeCom changes that are already present upstream

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc0a02d482

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/app/api/wecom.py Outdated
qianhaoq and others added 2 commits April 16, 2026 08:46
The 404 raised when no WeCom auth provider is available was being
swallowed by the broad `except Exception` handler, which converted it
into HTMLResponse with HTTP 200. Re-raise HTTPException before the
catch-all so status-based error handling and monitoring work correctly.

Addresses Codex review comment on backend/app/api/wecom.py:695.
@yaojin3616 yaojin3616 changed the title Fix setup interactivity and WeCom startup regression Fix setup interactivity and Python requirement alignment Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant