fix: bump electron to ^42.4.0 to fix binary extraction on Node 24#556
Merged
Conversation
electron@42.3.0 depended on extract-zip@2.0.1, which pins yauzl@2.10.0.
Under Node 24, yauzl@2.10.0 silently bails after the first zip entry, so
electron's install.js produced a partial dist/ with no path.txt and
require('electron') threw ENOENT, breaking `make electron-dev`.
electron 42.4.0 replaced the public extract-zip dependency with its own
dependency-free @electron-internal/extract-zip, removing the broken yauzl
chain at the source. Bumping the spec to ^42.4.0 resolves electron to
42.5.0 and drops extract-zip@2.0.1 / yauzl@2.10.0 from the tree entirely,
avoiding a package.json overrides hack.
Closes #555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make electron-devfailed on a fresh install under Node 24:electron@42.3.0depended onextract-zip@2.0.1→yauzl@2.10.0, which silently bails after the first zip entry on Node 24. Electron'sinstall.jsthen produced a partialdist/with nopath.txt, sorequire('electron')threwENOENT.Electron 42.4.0 replaced the public
extract-zipdependency with its own dependency-free@electron-internal/extract-zip, removing the brokenyauzlchain at the source. Bumping the spec to^42.4.0resolves electron to 42.5.0 and dropsextract-zip@2.0.1/yauzl@2.10.0from the tree entirely — avoiding apackage.jsonoverrideshack.Verified: binary extracts fully (
dist/version= 42.5.0,path.txtpresent),require('electron')resolves, and the frontendnpm run build(html-webpack-plugin) compiles cleanly.Closes #555