Fix/admin install anon auth#13
Merged
Merged
Conversation
carlosfunk
force-pushed
the
fix/admin-install-anon-auth
branch
from
060bcb9 to
00a7ca4
Compare
Collaborator
|
Would need to bump the |
kw-datamasque
requested changes
Jun 9, 2026
kw-datamasque
approved these changes
Jun 9, 2026
kw-datamasque
requested changes
Jun 9, 2026
Collaborator
|
Looks good and approved, with a nit and a question |
added 3 commits
June 10, 2026 10:20
…y installed' cleanly - New get_unauthenticated_client() factory in client.py; only requires DATAMASQUE_URL (no username/password) - admin-install and health switch to it; the endpoints themselves are anonymous and shouldn't gate on a token - admin-install catches 401 from /api/users/admin-install/ and returns ErrorCode.CONFLICT with a clear message Closes #12
…atamasque-python checkout - Add 'Running dm locally' section: editable install, env-var vs profile auth - Add cross-repo editable-install workflow for a sibling datamasque-python checkout
carlosfunk
force-pushed
the
fix/admin-install-anon-auth
branch
from
00a7ca4 to
5dfa199
Compare
kw-datamasque
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an issue when trying to use datamasque-cli to to do an admin install, it was requiring auth on a fresh install with no users.
/api/users/admin-install/is anonymous (as is healthcheck).get_unauthenticated_client()factoryadmin-installtranslates a 401 from/api/users/admin-install/into a clear "already installed" messageShips fine against the current
datamasque-pythonbut I also added a small change there to avoid retrying the when the admin-install returns a 401 once its already configured.Closes #12