Skip to content

IRI module#9

Open
daurnimator wants to merge 1 commit into
masterfrom
iri
Open

IRI module#9
daurnimator wants to merge 1 commit into
masterfrom
iri

Conversation

@daurnimator

Copy link
Copy Markdown
Owner

Solves #5

@tst2005

tst2005 commented Nov 15, 2016

Copy link
Copy Markdown

Hello,
Suggestion: put the utf8 check code into a separated lpeg_patterns/utf8.lua ?
I supposed that having a way to check utf8 could be used outside of the iri support.
Regards,

@daurnimator

Copy link
Copy Markdown
Owner Author

Suggestion: put the utf8 check code into a separated lpeg_patterns/utf8.lua ?

@tst2005 yeah I was thinking that. but I'm hesitating until I need to use it somewhere else: Returning codepoints as I have isn't very useful, and the range checks I have should be refactored before they become a public api (at the moment the utf8/ucschar pattern is not accessible directly)

@tst2005

tst2005 commented Nov 15, 2016

Copy link
Copy Markdown

@daurnimator No problem, I understand your choice ;)

@daurnimator

daurnimator commented Nov 15, 2016

Copy link
Copy Markdown
Owner Author

I think I'll need to write bindings to libunistring or similar to get normalisation and case folding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants