This repository was archived by the owner on Oct 28, 2022. It is now read-only.
RRT#5
Open
eejoylim wants to merge 4 commits into
Open
Conversation
andyblarblar
suggested changes
Apr 4, 2022
Collaborator
andyblarblar
left a comment
andyblarblar
left a comment
There was a problem hiding this comment.
Overall this looks like a good start, but needs some work. Outside of the suggestions already listed, I would suggest adding comments to functions and feilds describing their use case. This will go a long way in helping us look over your code.
It would also be very nice to see this being tested somehow, but I understand that isc_nav may not be capable of that yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.